Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

fix: add ExecutableDefinitions to ignored rules for validation #234

Merged
merged 2 commits into from
Jun 3, 2018
Merged

fix: add ExecutableDefinitions to ignored rules for validation #234

merged 2 commits into from
Jun 3, 2018

Conversation

divyenduz
Copy link
Contributor

  1. Add ExecutableDefinitions to ignored rules for schema validation

Copy link
Contributor

@asiandrummer asiandrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :D

@asiandrummer asiandrummer merged commit 068c57f into graphql:master Jun 3, 2018
@schickling schickling mentioned this pull request Jun 4, 2018
@danez
Copy link
Contributor

danez commented Jun 4, 2018

This breaks as it requires now graphql 0.12 at least but the peer dependency still has 0.10 as minimum version.

@schickling
Copy link
Contributor

Great point @danez. Unfortunately this wasn't caught by the tests. Do you think it's acceptable to increase the min peer dependency version to 0.12?

@danez
Copy link
Contributor

danez commented Jun 5, 2018

Yes, I updated our project to 0.13 and now it works (still with some workarounds for graphiql as some of its dependencies require 0.12, which means two different versions in our bundles.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants