Improve diagnostics tests #236
Conversation
| @@ -33,7 +33,7 @@ describe('GraphQLLanguageService', () => { | |||
|
|
|||
| it('runs diagnostic service as expected', async () => { | |||
| const diagnostics = await languageService.getDiagnostics( | |||
| 'qeury', | |||
| 'query', | |||
There was a problem hiding this comment.
This isn't a typo - as you see in line 39, this should expect a diagnostics error. Did this test pass with this change?
There was a problem hiding this comment.
Interesting, yes the tests passed for this change, it because with query it yields the following syntax error:
[ { severity: 1,
message: 'Syntax Error: Expected {, found <EOF>',
source: 'GraphQL: Syntax',
range: Range { containsPosition: [Function], start: [Object], end: [Object] } } ]
and with qeury it yields the following error:
[ { severity: 1,
message: 'Syntax Error: Unexpected Name "qeury"',
source: 'GraphQL: Syntax',
range: Range { containsPosition: [Function], start: [Object], end: [Object] } } ]
So, the errors are different but since we are only checking for the error count, the test passes.
Reverted it to qeury and added a new assertion to make it clearer that it is not a typo and make the test more robust.
| expect(errors.length).to.equal(0); | ||
| }); | ||
|
|
||
| it('returns no errors for valid query', () => { |
|
|
||
| it('returns no errors for valid query with aliases', () => { | ||
| const errors = getDiagnostics( | ||
| 'query { superHero: hero { superName :name } }', |
There was a problem hiding this comment.
nit: A better test case would also be:
'query { superHero: hero { superName: name } superHero2: hero { superName2: name } }'
| const errors = getDiagnostics( | ||
| ` | ||
| type Human implements Character { | ||
| SyntaxError |
There was a problem hiding this comment.
wat, not sure I understand SyntaxError as a field - maybe I'm not caught up with the current GraphQL spec. Could you elaborate here?
There was a problem hiding this comment.
Oops! my bad, I wanted to show that this is a syntax error i.e. type name without a named type definition. Using camel case was wrong, changing it.
There was a problem hiding this comment.
Used a verbose field_without_type_is_a_syntax_error for field name. Please let me know if I should change it :)
|
Thanks! |
Fix typo in language service test case
Add more test cases for diagnostics