-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookies are not being sent in Playground Express #748
Comments
With further searching, I found that the cookies can be turned on in settings. But is there a way to pass those options in Node? It's also complicated by the fact that I am using the playground behind Apollo Server. |
I have the same problem. app.get('/graphiql', expressGraphqlPlayground({
endpoint: '/graphql',
settings: {
'request.credentials': 'include',
},
})); If you have an idea ! Thanks ! |
Also using playground behind Apollo Server and having the same issue. |
Yes, I confirmed that this is still an issue. |
Yes, still an issue today, with const serverApollo = new ApolloServer({
typeDefs,
resolvers,
context: ({ req }) => {
return {...code...};
}
playground: {
settings: {
"request.credentials": "include"
}
}
}); It doesn't work! |
I am using this:
It still doesn't work. The same as @frederikhors |
And, I tried 'request.credentials': 'include', too. It doesn't work either. |
I am using
But still, the issue is there. Cookies are not being set. |
Here is what I found as a workaround:
{
- "request.credentials": "omit",
+ "request.credentials": "same-origin",
} Somehow, the client is not using the server settings, therefore it consumes |
@vladanpaunovic Yes, we use this too. |
That's not so much a workaround as the actual bug - the default user settings are always "omit" instead of the serverside defined default. |
I am trying to collect all these 'settings' issues in one place; I think it's beneficial that all of them are taken into consideration at once, lest we end up with partial fixes or fixes that break other stuff. Here's the place: #826 Could you all have a look and confirm the problem in this present issue has been captured in the one above? |
Is 'include' linked to boolean value false? Seems like because in my case both of the code works
Seems like the way it works is my access token is in cookie, So if I login from app, cookie is set |
Oh my god, I wasted so much time on this problem! @vladanpaunovic answer helped |
I was having what seemed like CORS issues with apollo-server behind OIDC authentication (Okta), and this was killing me. Thank you @vladanpaunovic !!! For anyone seeing |
Hi guys, using Apollo-server-express, I also got issue where the cookie wasn't sent with playground. After some trials an errors I found this solution that worked for me. Hope it helps someone. ApolloServerPluginLandingPageGraphQLPlayground({
settings: {
"request.credentials": "include",
"editor.reuseHeaders": false,
}
}) |
This works fine.Thank you |
For reference, the apollo fork of playground lives here: https://github.com/apollographql/graphql-playground If you have any issues with apollo server‘s fork of playground, you can visit apollo‘s spectrum support chat! |
I encountered this issue and after trying much of what has already been highlighted here, none still worked for me.
|
This issue pertains to the following package(s):
What OS and OS version are you experiencing the issue(s) on?
Ubuntu 16.04.4 LTS xenial
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
1.7.0
What is the expected behavior?
It should send browser cookies along with the GraphQL request.
What is the actual behavior?
The cookies are absent in the request originating from Playground.
What steps may we take to reproduce the behavior?
You can reproduce it with a demo app on glitch
/
, a cookie is set/graphql
and run a query{ hello }
You can see that Cookie is missing from Request Headers even though it is set in the browser
The cookie is hence not sent over to express
Note that the demo app runs on Apollo Server v2 which uses
apollo-server-express
version1.7.0
under the hood. I took the following screenshot from twitch terminal, insidenode_modules
The text was updated successfully, but these errors were encountered: