Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings are not being set/loaded consistently (Attempt to consolidate multiple issues) #826

Closed
4 of 7 tasks
vincenzo opened this issue Aug 27, 2018 · 2 comments · Fixed by #836
Closed
4 of 7 tasks

Comments

@vincenzo
Copy link
Contributor

vincenzo commented Aug 27, 2018

This issue pertains to the following package(s):

  • GraphQL Playground - Electron App
  • GraphQL Playground HTML
  • GraphQL Playground
  • GraphQL Playground Express Middleware
  • GraphQL Playground Hapi Middleware
  • GraphQL Playground Koa Middleware
  • GraphQL Playground Lambda Middleware

NOTE: I've only tried with Express Middleware, but since this issue is an attempt to consolidate different other issues, I am keeping the ticks from what I've seen elsewhere.

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

graphql-playground-middleware-express@1.7.4

What is the expected behavior?

  1. Setting a different default for request.credentials server side should take effect.
  2. Setting a different default for any setting server side should reflect the new default value in the Settings tab
  3. Setting a different default for only a subset of the settings should still be picking up the remaining default from the hardcoded values.

What is the actual behavior?

  1. No effect whatsoever.
  2. For any other setting other than request.credentials, setting a default seems to work, but the value shown in the settings tab won't reflect what's been set server side (e.g. set theme to light server side; it will take effect, but the settings tab will still show dark)
  3. If I set new defaults for two of the settings, other settings get no default at all, e.g. the font family won't be correct, thus messing the whole style up

What steps may we take to reproduce the behavior?

  1. Build a server app with express, use graphql-playground-middleware-express@1.7.4
  2. Instantiate server-side default for the settings as per above scenarios.

Related issues

There may be more.

@curry684
Copy link

For completion sake - same experiences with Koa middleware.

@vincenzo
Copy link
Contributor Author

Thanks @curry684; I added that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants