Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling next() after res.end() leads to [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client. #752

Closed
danlannz opened this issue Jul 1, 2018 · 1 comment
Closed

calling next() after res.end() leads to [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client. #752

danlannz opened this issue Jul 1, 2018 · 1 comment

Comments

@danlannz
Copy link

danlannz commented Jul 1, 2018 •
edited

current workaround is to check for res.finished in the following request handlers.
Is this functionality ever desired after the response stream has ended?

https://github.com/prismagraphql/graphql-playground/blob/62ecfdb658935a11391701835d15c66a06be68ad/packages/graphql-playground-middleware-express/src/index.ts#L27-L33
@evans evans mentioned this issue Jul 2, 2018
Closed
@andrefilimono
Copy link

Are there any updates?
This issue can be easily fixed ...

@dncrews dncrews mentioned this issue Feb 9, 2019
Merged
huv1k pushed a commit that referenced this issue Feb 23, 2019
@dncrews @huv1k
Avoid calling next() in Express middleware (#961)
21e6fba 
- fix #752
- fix #557
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this issue Mar 25, 2022
@dncrews @huv1k
Avoid calling next() in Express middleware (graphql#961)
1b22f4a 
- fix graphql#752
- fix graphql#557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danlannz @andrefilimono