Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting shareEnabled to false does not disable the share button. #860

Closed
2 of 7 tasks
andreduvoisin opened this issue Oct 16, 2018 · 0 comments · Fixed by #912
Closed
2 of 7 tasks

Setting shareEnabled to false does not disable the share button. #860

andreduvoisin opened this issue Oct 16, 2018 · 0 comments · Fixed by #912

Comments

@andreduvoisin
Copy link

This issue pertains to the following package(s):

  • GraphQL Playground - Electron App
  • GraphQL Playground HTML
  • GraphQL Playground
  • GraphQL Playground Express Middleware
  • GraphQL Playground Hapi Middleware
  • GraphQL Playground Koa Middleware
  • GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

Windows 10 Version 1709 (OS Build 16299.666)
Google Chrome Version 70.0.3538.67 (Official Build) (64-bit)

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

1.7.0 and 1.8.0

What is the expected behavior?

"Share Playground" button is disabled.

What is the actual behavior?

"Share Playground" button is enabled.

What steps may we take to reproduce the behavior?

Set shareEnabled: false in GraphQLPlayground.init() for the HTML version of Playground.

Exact options I'm running:

GraphQLPlayground.init(root, {
    endpoint: '/api/graphql',
    shareEnabled: false
})

Current workaround is to disable in the CSS, but since this changes per version, it's a bit of a struggle. In 1.8.0 this is:

.sc-hqyNC.bqVjBc {
    display: none;
}

Please provide a gif or image of the issue for a quicker response/fix.

shareenabledbug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants