Passed missing props from the Middlware #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pantharshit00
force-pushed
the
fix-share-bug
branch
from
2a372ce
to
1dc6d1a
Compare
|
@pantharshit00 Thanks for fixing this bug. |
cgxxv
pushed a commit
to cgxxv/graphql-playground
that referenced
this pull request
Mar 25, 2022
* fix: add shareEnabled option in the props * fix: pass fix endpoint from the props and removed unused redux code * fix: revert fixEndpoint removal from the store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #865, Fixes #860.
There are many unused and missing props as this code was written at first to support the custom needs of the graph cool framework.
I have passed
fixedEndpointandsharedEnableddown the component tree. There are many other props that are unused or unenabled. I guess we should gradually fix those.