Drop support for PromiseLike object in mutation resolvers (#364)

graphql · Dec 7, 2021 · 3cb8324 · 3cb8324
1 parent 691a529
commit 3cb8324
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 3 deletions.
diff --git a/src/mutation/__tests__/mutation-test.js b/src/mutation/__tests__/mutation-test.js
@@ -147,6 +147,53 @@ describe('mutationWithClientMutationId()', () => {
     });
   });
 
+  /* FIXME fail because of this https://github.com/graphql/graphql-js/pull/3243#issuecomment-919510590
+  it.only('JS specific: handles `then` as field name', async () => {
+    const someMutation = mutationWithClientMutationId({
+      name: 'SomeMutation',
+      inputFields: {},
+      outputFields: {
+        result: {
+          type: new GraphQLObjectType({
+            name: 'Payload',
+            fields: {
+              then: { type: GraphQLString },
+            },
+          }),
+        },
+      },
+      mutateAndGetPayload() {
+        return {
+          then() {
+            return new Date(0);
+          }
+        };
+      },
+    });
+    const schema = wrapInSchema({ someMutation });
+
+    const source = `
+      mutation {
+        someMutation(input: {clientMutationId: "abc"}) {
+          clientMutationId
+          result { then }
+        }
+      }
+    `;
+
+    expect(await graphql({ schema, source })).to.deep.equal({
+      data: {
+        someMutation: {
+          clientMutationId: 'abc',
+          result: {
+            then: '',
+          },
+        },
+      },
+    });
+  });
+  */
+
   it('can access rootValue', () => {
     const someMutation = mutationWithClientMutationId({
       name: 'SomeMutation',

diff --git a/src/mutation/mutation.js b/src/mutation/mutation.js
@@ -13,8 +13,6 @@ import type {
   Thunk,
 } from 'graphql';
 
-import isPromise from 'graphql/jsutils/isPromise';
-
 type MutationFn = (object: any, ctx: any, info: GraphQLResolveInfo) => mixed;
 
 function resolveMaybeThunk<T>(thingOrThunk: Thunk<T>): T {
@@ -90,7 +88,7 @@ export function mutationWithClientMutationId(
     resolve: (_, { input }, context, info) => {
       const { clientMutationId } = input;
       const payload = mutateAndGetPayload(input, context, info);
-      if (isPromise(payload)) {
+      if (payload instanceof Promise) {
         return payload.then(injectClientMutationId);
       }
       return injectClientMutationId(payload);