-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description field to mutationWithClientMutationId #61
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
resolves #57 |
Thanks for this, @christensenemc, and sorry about being slow to look at it. I think this looks basically good, but I'll add a couple of comments inline in your commit after this. |
@@ -83,6 +85,7 @@ export function mutationWithClientMutationId( | |||
|
|||
return { | |||
type: outputType, | |||
description: description, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is optional in GraphQLFieldConfig
, so we should probably omit it rather than return an empty string.
Looks like travis is failing on this babel-eslint bug |
Thanks for chasing down that babel-eslint issue! Good detective work. I left one more comment inline, but this looking great. |
Third time is the charm! It returns undefined on for field.description now if not in config. Better fits with the flow type, though personally I'm a little squeamish throwing around undefined like that. |
Would love to have the description field for graphiql documentation and introspection. |
Can we get a final rebase on this so that we can merge it without conflicts? |
Adds an optional description field to the mutationWithClientMutationId function.