Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow connection nodeType to be an interface #167

Closed

Conversation

jamiehodge
Copy link
Contributor

@jamiehodge jamiehodge commented Aug 8, 2017

Assuming that this does not violate the connection spec, allow the nodeType to be of type GraphQLInterfaceType.

Addresses: #160

I was somewhat confused by the existing connection spec. Would someone please advise regarding testing?

I'm mentioning @leebyron as well, to confirm that this doesn't violate the intent of one of the various GraphQL specs.

@jamiehodge
Copy link
Contributor Author

@leebyron @wincent ?

@@ -11,6 +11,7 @@
import {
GraphQLBoolean,
GraphQLInt,
GraphQLInterfaceType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an import type anyway, regardless of whether it's appropriate.

@yongwee
Copy link

yongwee commented Jan 8, 2018

Hi @jamiehodge do you plan to go ahead with this? I'm running into the same problem on my end 😅
Also, what about including GraphqlUnionType too?

@jaydenseric
Copy link

It can be pretty much anything except a list:

This field must return either a Scalar, Enum, Object, Interface, Union, or a Non‐Null wrapper around one of those types. Notably, this field cannot return a list.
https://facebook.github.io/relay/graphql/connections.htm#sec-Node

Base automatically changed from master to main February 10, 2021 15:10
IvanGoncharov added a commit to IvanGoncharov/graphql-relay-js that referenced this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants