Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change toGlobalId ID parameter to be either string or number #219

Closed
wants to merge 1 commit into from

Conversation

intellix
Copy link

Closes #218

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.46% when pulling 11fb043 on intellix:patch-1 into da2801a on graphql:master.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sibelius
Copy link
Contributor

sibelius commented Jan 7, 2019

it makes sense

Base automatically changed from master to main February 10, 2021 15:10
@kassens
Copy link
Contributor

kassens commented Jun 5, 2021

I'm pretty out of the loop of this code, but fromGlobald is the opposite and returns a string. Might be nice to keep this a bijection?

IvanGoncharov added a commit to IvanGoncharov/graphql-relay-js that referenced this pull request Jun 22, 2021
IvanGoncharov added a commit that referenced this pull request Jun 22, 2021
@intellix intellix deleted the patch-1 branch June 22, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toGlobalId expects ID as a string
6 participants