Use $ReadOnlyArray type for connection data #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi good people 馃憢
I would like to suggest to use more strict type for connection data -
$ReadOnlyArray<T>
Why?
We define all our types for data on GraphQL server as read-only, so passing data to
connectionFromArray
fails on flow unless we change the type to normal array or do workaround like[...children]
:With these changes, it should be possible to opt-in for
$ReadOnlyArray<T>
whileArray<T>
would still work as well.