Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update for graphql-js v15.x #242

Closed
wants to merge 2 commits into from
Closed

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 3, 2020

No description provided.

@taion
Copy link
Contributor Author

taion commented Apr 3, 2020

cc @kassens – if you have a moment to pull this in, so we can get the right peer dependency

@TrySound
Copy link

Friendly ping @kassens

@glen-84 glen-84 mentioned this pull request Jul 24, 2020
@glen-84
Copy link

glen-84 commented Jul 24, 2020

Closes #245.

@anchan828
Copy link

any updates? graphql-relay needs to support graphql v15.x
I got npm v7 error: ERESOLVE unable to resolve dependency tree

# npm resolution error report

2020-10-23T01:20:43.965Z

While resolving: my-app@1.0.0
Found: graphql@15.3.0
node_modules/graphql
  graphql@"15.3.0" from the root project

Could not resolve dependency:
peer graphql@"^0.5.0 || ^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0" from graphql-relay@0.6.0
node_modules/graphql-relay
  graphql-relay@"0.6.0" from the root project

Fix the upstream dependency conflict, or retry
this command with --force, or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

Raw JSON explanation object:

{
  "code": "ERESOLVE",
  "current": {
    "name": "graphql",
    "version": "15.3.0",
    "whileInstalling": {
      "name": "my-app",
      "version": "1.0.0",
      "path": "/home/anchan828/repos/my-app"
    },
    "location": "node_modules/graphql",
    "dependents": [
      {
        "type": "prod",
        "name": "graphql",
        "spec": "15.3.0",
        "from": {
          "location": "/home/anchan828/repos/my-app"
        }
      }
    ]
  },
  "edge": {
    "type": "peer",
    "name": "graphql",
    "spec": "^0.5.0 || ^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0",
    "error": "INVALID",
    "from": {
      "name": "graphql-relay",
      "version": "0.6.0",
      "whileInstalling": {
        "name": "my-app",
        "version": "1.0.0",
        "path": "/home/anchan828/repos/my-app"
      },
      "location": "node_modules/graphql-relay",
      "dependents": [
        {
          "type": "prod",
          "name": "graphql-relay",
          "spec": "0.6.0",
          "from": {
            "location": "/home/anchan828/repos/my-app"
          }
        }
      ]
    }
  },
  "peerConflict": null,
  "strictPeerDeps": false,
  "force": false
}

@glen-84
Copy link

glen-84 commented Oct 26, 2020

@IvanGoncharov Is this project still maintained?

@IvanGoncharov
Copy link
Member

@glen-84 Yes, it is.
Sorry for the delay.
I Will work on a new release.
The long term plan is to merge this functionality into graphql-js to simplify maintenance.

@glen-84
Copy link

glen-84 commented Feb 7, 2021

@IvanGoncharov Friendly ping.

Base automatically changed from master to main February 10, 2021 15:10
@taion
Copy link
Contributor Author

taion commented Feb 13, 2021

No reason to keep this PR open any more, anyway, given that #266 was merged.

@taion taion closed this Feb 13, 2021
@taion taion deleted the graphql-15 branch February 13, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants