Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Add Validation rule for unique directives per location. #229

Merged
merged 1 commit into from Oct 29, 2016
Merged

[RFC] Add Validation rule for unique directives per location. #229

merged 1 commit into from Oct 29, 2016

Commits on Oct 29, 2016

  1. [RFC] Add Validation rule for unique directives per location. 

    This rule was suggested by @jjergus (#223) to remove ambiguity from execution where the `@skip` and `@ignore` directive rules make the assumption that only one is defined per selection.

In general I think this assumption should be upheld by valid queries overall, not just for `@skip` and `@include` so that it can be relied upon for any usage of directives. For example, this allows a potential optimization to use a hashmap keyed on directive name to represent the directives at a location rather than an array.

Closes #223
    @leebyron
    leebyron committed Oct 29, 2016
    Copy the full SHA
    8977618 View commit details
    Browse the repository at this point in the history