Add constraints to EnumValue
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the formatting for constraints to be a little easier to read IMO. Also, adds the disambiguating constraints to `EnumValue`.
leebyron
added a commit
that referenced
this pull request
Jul 16, 2015
Add constraints to `EnumValue`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the formatting for constraints to be a little easier to read IMO.
Also, adds the disambiguating constraints to
EnumValue.Where I'd like feedback is on constraining
EnumValueto not includenull. I think this has the possibility to be a point of confusion.nullas an EnumValue is a pitfall, at best it's confusing. This effectively makes the use ofnullas a literal a syntax error (and buys us the option value of including it as a true literal in the future).If feedback is positive, I'll find references to this in the spec and tests and clean them up.