Clarify Number parsing, expand exponent grammar #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
numbers
branch
4 times, most recently
from
e8f30d6
to
1d9fac5
Compare
This makes Number parsing match the JSON spec for numbers, reducing the chances for naive error. It also hopefully clarifies the non-zero leading case for numbers in `IntegerPart`.
leebyron
added a commit
that referenced
this pull request
Jul 16, 2015
Clarify Number parsing, expand exponent grammar
leebyron
added a commit
to graphql/graphql-js
that referenced
this pull request
Jul 16, 2015
Ensures graphql-js matches spec after graphql/graphql-spec#56 Adds tests for changed error and success cases, fixing #68
andimarek
added a commit
to graphql-java/graphql-java
that referenced
this pull request
Jul 17, 2015
amarant
added a commit
to amarant/GraphQLSharp
that referenced
this pull request
Jul 17, 2015
Ensures graphql-js matches spec after graphql/graphql-spec#56 Adds tests for changed error and success cases. Like ca5749621b122b1cf92101f43a01a446b922b57f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Number parsing match the JSON spec for numbers, reducing the chances for naive error.
It also hopefully clarifies the non-zero leading case for numbers in
IntegerPart.