Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Custom Scalar Specification URLs #649

Merged
merged 25 commits into from
Apr 9, 2021
Merged

[RFC] Custom Scalar Specification URLs #649

merged 25 commits into from
Apr 9, 2021

Commits on Apr 9, 2021

  1. First draft of spec changes for the scalar RFC

    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    5a2e3e3 View commit details
    Browse the repository at this point in the history

  2. Add a bit about changing the URI 

    As Benjie noted, it's a bad idea (though not strictly breaking, if the
spec has simply moved).

Also tidy up the previous paragraph a bit.
    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    2e24437 View commit details
    Browse the repository at this point in the history

  3. Clarify some points raised at working group

    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    1d1cf95 View commit details
    Browse the repository at this point in the history

  4. switch to a directive

    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    22d2921 View commit details
    Browse the repository at this point in the history

  5. Minor fixes based on feedback

    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    9a599f6 View commit details
    Browse the repository at this point in the history

  6. Use "URL" instead of "RFC3986-compliant URI" 

    They're not quite the same thing, but URL is what we actually mean even
if it's less formally specified.
    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    bc9a408 View commit details
    Browse the repository at this point in the history

  7. Tweak introspection language 

    Not all scalars will have a `specifiedBy` value so "should" was too
strong.
    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    2c2057e View commit details
    Browse the repository at this point in the history

  8. Use UUID as a less controversial example 

    Also fix a few more URI->URL references.
    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    a620718 View commit details
    Browse the repository at this point in the history

  9. Update directive name to @SpecifiedBy

    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    5522c9a View commit details
    Browse the repository at this point in the history

  10. Tweak language

    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    2ed5043 View commit details
    Browse the repository at this point in the history

  11. Americanize spelling in spec/Section 3 -- Type System.md 

    Co-Authored-By: Matt Farmer <work@mattfarmer.net>
    @eapache @m14t @leebyron
    2 people authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    50b5510 View commit details
    Browse the repository at this point in the history

  12. Add link to RFC4122 

    Co-Authored-By: Lee Byron <lee@leebyron.com>
    @eapache @leebyron
    eapache and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    e235752 View commit details
    Browse the repository at this point in the history

  13. Update spec/Section 4 -- Introspection.md 

    Co-Authored-By: Lee Byron <lee@leebyron.com>
    @eapache @leebyron
    eapache and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    42360e4 View commit details
    Browse the repository at this point in the history

  14. Minor wording and formatting tweaks

    @eapache @leebyron
    eapache authored and leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    4b5a285 View commit details
    Browse the repository at this point in the history

  15. Editorial

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    968f961 View commit details
    Browse the repository at this point in the history

  16. Editorial for Scalars section

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    6c58094 View commit details
    Browse the repository at this point in the history

  17. Editorial to reduce duplication and centralize info

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    bab4fab View commit details
    Browse the repository at this point in the history

  18. Editorial - grammar

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    038b6f8 View commit details
    Browse the repository at this point in the history

  19. Editorial - simplify introspection change

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    eb18c03 View commit details
    Browse the repository at this point in the history

  20. Editorial - introspection description

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    96fb0d1 View commit details
    Browse the repository at this point in the history

  21. Editorial - return note about use of descriptions

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    f8065c3 View commit details
    Browse the repository at this point in the history

  22. Editorial - directive description

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    a2401b7 View commit details
    Browse the repository at this point in the history

  23. Update Section 3 -- Type System.md

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    318b753 View commit details
    Browse the repository at this point in the history

  24. address review

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    f2bf007 View commit details
    Browse the repository at this point in the history

  25. additional editorial adjustment

    @leebyron
    leebyron committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    89014b9 View commit details
    Browse the repository at this point in the history