Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2021-04-01] Scan GraphQL org for outdated (Facebook) copyright notices #662

Closed
benjie opened this issue Apr 2, 2021 · 3 comments
Closed

Comments

@benjie
Copy link
Member

benjie commented Apr 2, 2021

Lee: is anyone aware of outstanding issues here?
Ivan: I can do a check. I will search for “Facebook” under the GraphQL org
[ACTION - Ivan]: see if there's any outdated Facebook copyright notices in GraphQL org


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie benjie added this to To do in Actions 2021-04-01 via automation Apr 2, 2021
@leebyron
Copy link
Collaborator

leebyron commented Sep 2, 2021

Remaining:

  • Swapi
  • GraphQL.org

Need to do final scan

@brianwarner
Copy link
Contributor

I did a spot check and the copyright lines look alright to me. We generally don't require those to be changed and in fact, nobody else can/should change Facebook's copyright line other than an authorized person from the company. We generally recommend projects follow Steve Winslow's writeup on the topic. The good news is, it can stay as it is and be totally fine. That said, if some enterprising person wanted to add an additional copyright line that says "Copyright GraphQL contributors" (note there's no year in there), it'll be evergreen and won't ever need to be revved.

That said, we should have a look at the license files in these two repos. And by "we", I mean, "I"...

I can take this one, @IvanGoncharov. I'll reassign it to myself.

leebyron added a commit to graphql/graphql.github.io that referenced this issue Sep 3, 2021
See graphql/graphql-wg#662 for context.

This is a very focused change. Note that there are still a few code files which are "Copyright Facebook". I personally wrote those original files and haven't bothered changing them. (See why: https://www.linuxfoundation.org/blog/copyright-notices-in-open-source-software-projects/)

However future code and usage is governed by our LICENSE file, which we standardize as MIT including a general "Copyright (c) GraphQL Contributors". Same as our other repositories
leebyron added a commit to graphql/dataloader that referenced this issue Sep 3, 2021
leebyron added a commit to graphql/libgraphqlparser that referenced this issue Sep 3, 2021
leebyron added a commit to graphql/foundation that referenced this issue Sep 3, 2021
leebyron added a commit to graphql/graphql.github.io that referenced this issue Sep 3, 2021
See graphql/graphql-wg#662 for context.

This is a very focused change. Note that there are still a few code files which are "Copyright Facebook". I personally wrote those original files and haven't bothered changing them. (See why: https://www.linuxfoundation.org/blog/copyright-notices-in-open-source-software-projects/)

However future code and usage is governed by our LICENSE file, which we standardize as MIT including a general "Copyright (c) GraphQL Contributors". Same as our other repositories
leebyron added a commit to graphql/graphiql that referenced this issue Sep 3, 2021
leebyron added a commit to graphql/graphiql that referenced this issue Sep 3, 2021
leebyron added a commit to graphql/swapi-graphql that referenced this issue Sep 3, 2021
@leebyron
Copy link
Collaborator

leebyron commented Sep 3, 2021

Thanks for that link, fascinating read!

I scanned through our repos looking specifically at the LICENSE files and found some variation which I cleaned up to all use the same MIT copy and evergreen copyright notice.

I left individual files alone, as suggested

@leebyron leebyron closed this as completed Sep 3, 2021
Actions 2021-04-01 automation moved this from To do to Done Sep 3, 2021
Eandalf7h added a commit to Eandalf7h/graphql that referenced this issue Nov 27, 2021
hiukky7e added a commit to hiukky7e/graphqlb that referenced this issue Nov 27, 2021
@benjie benjie added this to To do in Actions 2021-09-02 via automation Nov 28, 2021
@benjie benjie moved this from To do to Done in Actions 2021-09-02 Nov 28, 2021
jonathan-briere added a commit to jonathan-briere/swapi-graphql that referenced this issue Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants