Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: invalid/404 link in docs. #1055

Closed
aghArdeshir opened this issue Jun 2, 2021 · 2 comments · Fixed by #1056
Closed

DOCS: invalid/404 link in docs. #1055

aghArdeshir opened this issue Jun 2, 2021 · 2 comments · Fixed by #1056

Comments

@aghArdeshir
Copy link

In documentation of graphql, Validation page (https://graphql.org/learn/validation/) there is a link in second paragraph, pointing to a file in github. but github return 404 Not Found.

This is where the link points to: https://github.com/graphql/graphql-js/blob/main/src/__tests__/starWarsValidation-test.js
@aghArdeshir
Copy link
Author

There is another one in https://graphql.org/learn/introspection/

@brianwarner
Copy link
Contributor

Good catch @aghArdeshir, PR inbound shortly.

brianwarner added a commit that referenced this issue Jun 2, 2021
@brianwarner
Fix .js -> .ts links after TypeScript conversion
b7e60c3 
Some of the examples in /learn linked directly to .js files in GraphQL.js that have since been
converted to .ts files.

Closes #1055

Signed-off-by: Brian Warner <brian@bdwarner.com>
@brianwarner brianwarner mentioned this issue Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix .js -> .ts links after TypeScript conversion graphql/graphql.github.io
2 participants
@brianwarner @aghArdeshir