Removed all warnings from cgdb #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… subclasses are deleted, they are actually deleted rather than undefined behaviour
… removes unused parameter warning due to the fact that the base method just returns false
…ices, and are always greater than 0.
mateiciocarlie
added a commit
that referenced
this pull request
Dec 10, 2015
Removed all warnings from cgdb
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with
CONFIG += cgdb
There are no longer any warnings. The only warning that I fixed that may have been causing issues was adding virtual destructors to DatabaseManager and GraspAllocator. Without doing this, then deleting their subclasses has undefined behaviour.
Compiles and runs on my linux machine. I was not able to fully test all the cgdb code as I don't have a version of the cgdb that works with this version of graspit.
The current copy of cgdb does work with this branch of graspit:
jvarley@c696caa
I have a PR coming for this as well.