Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give screeplot an ax argument #840

Closed
loftusa opened this issue Sep 19, 2021 · 10 comments · Fixed by #1048
Closed

Give screeplot an ax argument #840

loftusa opened this issue Sep 19, 2021 · 10 comments · Fixed by #1048
Assignees
Labels
api enhancement New feature or request good first issue Good for newcomers
Projects

Comments

@loftusa
Copy link
Collaborator

loftusa commented Sep 19, 2021

function here.

Currently no way to specify an ax, most other plotting functions have that unless there's a good reason not to. I don't see a good reason for this one not to have it. Should be pretty easy to add on.

@loftusa loftusa added enhancement New feature or request good first issue Good for newcomers api labels Sep 19, 2021
@himanshu007-creator
Copy link

Hi, i would like to work on this issue, shall i take it?!🙂

@loftusa
Copy link
Collaborator Author

loftusa commented Sep 21, 2021

Hi, i would like to work on this issue, shall i take it?!🙂

Sure. Just want to be able to specify a matplotlib axis if i'm using the screeplot function.

@bdpedigo bdpedigo added this to Maintenance in bdpedigo Jan 28, 2022
@bdpedigo bdpedigo moved this from Maintenance to In progress in bdpedigo Jan 28, 2022
@bdpedigo bdpedigo moved this from In progress to Needs review in bdpedigo Jan 28, 2022
@rookiexiong7
Copy link

Is this work still ongoing?I am a beginner and would like to give it a try.

@kidkoder432
Copy link
Contributor

I think you can still PR, as it hasn't been closed. I'm going to try it as well :)

@MuLIAICHI
Copy link

Greeting, did anyone try to PR that issue ?

@kidkoder432
Copy link
Contributor

kidkoder432 commented Sep 17, 2023 via email

@MuLIAICHI
Copy link

They should really bay attention here !

@kidkoder432
Copy link
Contributor

kidkoder432 commented Sep 25, 2023 via email

@bdpedigo
Copy link
Collaborator

FYI this was closed automatically since the PR was merged #1048 :)

@MuLIAICHI
Copy link

Ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request good first issue Good for newcomers
Projects
bdpedigo
Needs review
6 participants