Fixed graph matching with similarity matrix of unequal dimensions #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: the mypy error I get, is an output type of I have impression that it returns a matrix, so |
bdpedigo
changed the title
bdpedigo
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
@dokato thanks for the PR, this looks good to me now. I added a test. I also wanted to make sure that naive padding is always used here. Mathematically, the similarity matrix does not need to be padded, but in the code (as you suggest) it is easier to just pad that matrix to make it bigger because of how the current code is written to assume it is square. However, I wanted to make sure that we aren't actually changing the objective function value by doing that padding (so, we make sure we only add 0s)
j1c
pushed a commit
that referenced
this pull request
Dec 10, 2022
* Fix seaborn syntax * Increment bugfix version * Exclude 3.6.1 I added to line 35. I assumed the asterisk on 3.3 meant all versions of 3.3 ex (3.3.1, 3.3.2) are all excluded from the matplotlib. Is this correct? * Update setup.cfg * Update README.md Removed outdated Zenodo DOI from README.md * Fixed graph matching with similarity matrix of unequal dimensions (#1002) * Fix seaborn syntax * fixed padding of a similarity amtrix for graph matching * fixing mypy complaint from _adj_pad * use naive padding for similarity * add a test * Revert "Fix seaborn syntax" This reverts commit fd38e05. * try to fix ipython error in doc generation * just make sure the original S had the right shape * run black * fix tests Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com> * Edited contributing guidelines (#1000) * Editing contributing guidelines My edits were based on my experience with getting set up on GitHub. I added some minor changes of things I wish I had read while I was trying to set up my account. * fix typo Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com> * Update setup.cfg (#999) * Added release notes for 2.0.1 (#1003) Co-authored-by: Dax Pryce <daxpryce@microsoft.com> Co-authored-by: hugwuoke <85888975+hugwuoke@users.noreply.github.com> Co-authored-by: Kartikeya Tripathi <96724863+ktwillcode@users.noreply.github.com> Co-authored-by: dokato <dkk33@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1001.
What does this implement/fix? Briefly explain your changes.
_compare_dimensionschecks are passing.