hard capped networkx version to avoid incompatability #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdpedigo
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
thanks for the quick catch on this @alyakin314! only change was making this <= in case new releases come out
|
@bdpedigo sure. only reason i did it this way was because all other packages seemed to have |
bdpedigo
added a commit
that referenced
this pull request
Mar 23, 2023
* hard capped networkx version to avoid incompatability * set networkx to <= 3.0 * Update setup.cfg Co-authored-by: alyakin314 <antonalyakin@Antons-MacBook-Pro-4.local> Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
bdpedigo
added a commit
that referenced
this pull request
Mar 24, 2023
* hard capped networkx version to avoid incompatability * set networkx to <= 3.0 * Update setup.cfg Co-authored-by: alyakin314 <antonalyakin@Antons-MacBook-Pro-4.local> Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems so
nope
nope
irrelevant
unapplicable?
Reference Issues/PRs
Fixes #1015.
What does this implement/fix? Briefly explain your changes.
Quick-patches the incompatibility by avoiding the netoworkx v.3.0.
Any other comments?
Probably need a better long term fix. Unsure if removing the orderedgraph arguments is sufficient and/or backward compatible.