Fixed NetworkX 3 compatibility and switched to sparse arrays (not matrices) #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdpedigo
force-pushed
the
dev
branch
2 times, most recently
from
0823390
to
aebdf1e
Compare
bdpedigo
changed the title
bdpedigo
changed the title
tathey1
reviewed
Mar 27, 2023
@tathey1 vs code has a "rename symbol" command that can do it all in one go |
tathey1
approved these changes
Mar 27, 2023
bdpedigo
added a commit
that referenced
this pull request
May 22, 2023
…rices) (#1018) * Update setup.cfg * add conditional types logic for pipeline * fix a reference to sparse matrix * remove all reference to csr_matrix * fix array * remove nx.testing * fix graphs equal * fix some weird reversions to csr_matrix * remove OrderedGraph support * fix tutorial reference to csr_array --------- Co-authored-by: hugwuoke <85888975+hugwuoke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #961
Proper fix of #1015
What does this implement/fix? Briefly explain your changes.
Any other comments?
nx.OrderedGraph, but I'm not losing and sleep over that one. I was even considering just switching to NetworkX 3 support only but I don't think it's fully necessary.