Cursor grab/grabbing #319
Open
Cursor grab/grabbing #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! |
|
Sorry this is like my side side side hobby and other things took priority, could you show me some screenshots of the changes? Also, you can use this script to make the HTML files: https://github.com/grassmunk/Chicago95/blob/master/Extras/make_html.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the cursor for grabbing. For now I only did it with animated hourglass, it would be nice if it was added to other themes as well, but I'm not too familiar with these things yet. I also updated the icon cache (fixes #315), which I forgot to do in my last pull request. I still haven't updated icon htmls as I don't know how to. When I was editing the cursor gen script I just moved things around, I hope I didn't make any mistakes. Running the
cursors_gen.pyscript changed my hourglass to black and white style, please take a look what's going on there.Have you considered adding multiple cursor sizes? This way the user could select the size, getting rid of the need for separate HiDPI cursors. Windows 95 includes multiple cursor sizes, I think they would be appropriate here.