Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

New notifications system blocks nav bar and takes a long time to go away #2273

Closed
seanlinsley opened this issue Apr 13, 2014 · 8 comments
Closed

Comments

@seanlinsley
Copy link
Contributor

screen shot 2014-04-13 at 5 57 38 pm

@seanlinsley
Copy link
Contributor Author

15 seconds, specifically

@rummik
Copy link
Contributor

rummik commented Apr 13, 2014

Suggestions? :D My thoughts are we could add a close button (still blocks nav...) or have them at the bottom of the page. Dunno if either of them are necessarily ideal though

@ESWAT
Copy link

ESWAT commented Apr 14, 2014

Given the fixed-width layout and the amount of space we have around it, maybe we can put it at one of the bottom corners.

@clone1018
Copy link
Contributor

We need something soon :( Can we act fast on this one?

@juliepagano
Copy link
Contributor

Just popped over to complain about this and am glad to see other folks are already on it. ;)

Seems like a quick fix would be to adjust the timeout to something more reasonable. Maybe around 5 seconds or a little less? I don't have time to test it at the moment, but it looks like you might just need to adjust it in the line linked below.

https://github.com/gittip/www.gittip.com/blob/c61245a91560173163c32aaa7b07afa29f69f4c1/js/gittip/notification.js#L16

@duckinator
Copy link
Contributor

Personally, the nicest approach I've seen has been shifting the entire page down the height of a notification, and adding the notifications above it.

If we go with that approach, however, I'd suggest pushing a temporary fix that drops the timeout (as @juliepagano suggested) until it is ready: that approach will take a while to implement well.

What are your thoughts, @rummik?

@seanlinsley
Copy link
Contributor Author

#2279 is now on production, which makes a few small changes that greatly improve usability.

duckinator pushed a commit that referenced this issue Apr 16, 2014
Quick fix for #2273 to improve usability until a long-term solution is
agreed on and implemented.
@rummik
Copy link
Contributor

rummik commented Apr 21, 2014

@juliepagano It's not merged yet, but #2308 should fix the issue you've pointed out.

@rummik rummik closed this as completed in 183681c Apr 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants