add bitcoin receiving address to profile

[galuszkak]

Rebase to master PR #1437 for fixing #1163

Please review. :)

Tests seems that works.

[chadwhitacre]

I changed the title to the old one from #1437 for better scanability in the PR listing.

[zwn]

I am reviewing this PR. Do we want to keep our own copy of bitcoin validation code in bitcoin.json.spt? I see that there exists python-bitcoinaddress package that we could use. The validation code in this PR is pretty simplistic - it throws ValueError if there is a character in the bc address that is not allowed, thus creating false report in Sentry (logs all exceptions in production). I would also appreciate having the input box large enough to actually see the address I am entering (maybe put the save & cancel buttons under the input box instead of next to it?), also the edit link is not very touch friendly (too small).

We need to

• either fix the code so it does not throw exceptions or include a package that does the work for us - @whit537 which one?
• adjust the UI so it is more usable - @rummik @duckinator @seanlinsley @clone1018 - wanna review the UI?

[galuszkak]

@zwn +1 for validation.

I didn't think about all these things. My first step was to integrate all @reedlaw changes to master. I think using python-bitcoinaddress is really good idea.

To UI changes I think they are much more easy to add. :)

Thanks for input @zwn

[zwn]

@galuszkak To add a new package to gittip you download it from pypi and put the tarball to vendor directory and a reference to it to the requirements.txt file (see the file for examples). The goal being here that we have everything at hand at deploy time and it is also pinned so it does not change without us noticing. If something is not obvious feel free to ask question (here or at irc).

[zwn]

One more thing - the current validation code allows me to prepend additional characters and still considers the address valid. That does not seem right (but I know close to nothing about bitcoin).

>>> check_bc('1AGNa15ZQXAZUgFiqJ2i7Z2DPU2J6hW62i')
True
>>> check_bc('111111111AGNa15ZQXAZUgFiqJ2i7Z2DPU2J6hW62i')
True

[zwn]

Could you please also factor out the changes done to schema.sql into a separate branch.sql? Are you familiar with this concept already? We need to add a description somewhere #1846. Changes to db schema are introduced in a separate file branch.sql and only folded to schema.sql after a merge to master. We need this for deployment of the changes and easy updates of the production database (sourcing the branch.sql file into psql for updates). I would have done it myself but you are not working on a branch where I do not have access to.

[galuszkak]

@zwn no problem. I was curious why this was in seperate file like branch.sql. Ok I will add this there.

[galuszkak]

@zwn updated.

@whit537 when I was fixing test I was little confused what changed in tests api. This should be noted somewhere for other people.

[zwn]

@galuszkak Thanks! I am almost happy. Can we do something about the tiny size of the edit link? I can hardly hit it with a mouse. I can't imagine what a user with a touch screen would do.

@seanlinsley Do I remember right that that you were the one trying to make the site more responsive and touch friendly? Maybe you could help here too. Thanks.

[galuszkak]

@zwn no problem. I will update

[galuszkak]

@zwn updated. please check

[zwn]

Thanks. Since no one has voiced any concerns about the UI (I am not an UI person) I am going to merge.
So, last call 😉

[seanlinsley]

I just tested the UI locally, and it looks good to me 🐱

[seanlinsley]

Shouldn't this be 100%?

[galuszkak]

I didn't need more that is why I didn't used 100% because 400px was ok and whole address was seen in input very clearly.