Team creation #3412
Team creation #3412
Conversation
rohitpaulk
force-pushed
the
team-creation
branch
2 times, most recently
from
24f040a
to
b4bf43d
Compare
|
@whit537 - I feel like we're approaching this the wrong way. We're going to deliver a bad user experience if we attempt to get this done before tomorrow. If only a handful of teams (including us) are going to take part in this payday, why not collect the question/answers from them (via email) manually? Shouldn't we focus on getting a few 'beta' users and processing payments for them first? I'm suggesting that we let this (building an application process) wait, and focus on how we're going to run Payday this Thursday. |
|
I definitely agree that our focus is on getting payday run this Thursday with a few beta users. If we don't widely advertise the |
Ah, okay :) |
|
I've been thinking about i18n for this. I don't think we need a full multi-language implementation like we've got for statements, because a team is going to have one primary language they work in. They can just answer the questions in whatever language they want (though that'll pose an interesting challenge in terms of our ability to review new teams). I think it would be good to have a "primary language" field for Teams (which should be pretty easy to implement), but beyond that I don't think we need to worry about i18n. |
|
More important is that the form needs to include a checkbox to accept the terms of service. |
rohitpaulk
force-pushed
the
team-creation
branch
2 times, most recently
from
60cfdd8
to
6f06e26
Compare
|
Rebased on master. |
|
Not the best UX, but it works. Tagging as ready for review... |
|
Awesome! I'm working on terms (#3408), and I'll look at this next. |
|
We want to require some things of participants before we allow them to register:
|
chadwhitacre
force-pushed
the
team-creation
branch
from
3beff72
to
c1caf74
Compare
|
Alright, I'm satisfied with this as far as it goes. We shouldn't merge this until #3408 lands, because the whole point is to have people accept our new terms. Also, anyone using this will need their tips migrated or it's all for naught. Migrating tips depends on the schema that's to be built on #3414. Therefore, I think we need to hold tight with this PR for now. I guess we may as well implement migration on this PR since we're blocked on it. |
|
The migration experience should be that if a user creates a team, and that user has |
We can do that independently of this PR. Unblocking on migration. Still blocked on #3408. |
|
@whit537 - Who'd be the owner of the Gratipay team? |
|
The |
teams/create.json
Python lesson time! :D
Python dicts are mutable, which means that this will modify foo:
>>> foo = {1: 2}
>>> bar = foo
>>> bar[1] = 3
>>> foo
{1: 3}
You can tell that foo and bar are the same identical object by comparing
their memory address:
>>> id(foo) == id(bar)
True
An easy way around this is to make a shallow copy using the dict
constructor (shallow means non-recursive):
>>> foo = {1: 2}
>>> bar = dict(foo)
>>> bar[1] = 3
>>> foo
{1: 2}
>>> id(foo) == id(bar)
False
- must have a verified email - must have a payout route - can't be stub, closed, or suspicious
We don't need to migrate when the user applies. We need to migrate before we run payday. Users can apply for a team and we can migrate later.
chadwhitacre
force-pushed
the
team-creation
branch
from
756a753
to
240aa19
Compare
|
Rebased on master post-#3408. |
Restructured a bit to fit this.
|
Error messages should link to the form that needs to be completed (in my case, I hadn't verified my email address on the settings form, but I suspect that filling out the identity form also prevented a similar error). |
|
Ah, and now I need to attach a bank account (also still not linking to the appropriate form). May I suggest that if several requirements are not met, the error message list all of them, rather than making us play whack-a-mole? |
|
@webmaven Yeah, we cut UX corners in the interest of time, sorry. :-( |
|
Reticketed as #3422. |
For #3399. cc: @rohitpaulk