This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Throttle better #4349
Merged
Throttle better #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is somewhat complicated by the fact that we don't want system-generated emails to affect throttling, only user-initiated messages. |
25 tasks
chadwhitacre
force-pushed
the
simplify-verify
branch
from
9b1e484
to
4b89849
Compare
chadwhitacre
force-pushed
the
throttle-better
branch
from
d289494
to
9f3fd12
Compare
|
Alright! All caught up after making upstream changes (see chain listed under "new email subflooring" pre-req on #4305). Ready to make progress here again, I think ... |
|
!m @whit537! |
chadwhitacre
force-pushed
the
simplify-verify
branch
from
4b89849
to
1d6915c
Compare
chadwhitacre
force-pushed
the
throttle-better
branch
from
9f3fd12
to
eacbc1d
Compare
chadwhitacre
force-pushed
the
simplify-verify
branch
from
1d6915c
to
012ce92
Compare
chadwhitacre
force-pushed
the
throttle-better
branch
3 times, most recently
from
3a99e40
to
ea2c77f
Compare
Typo in ea2c77f. 😊 |
chadwhitacre
force-pushed
the
throttle-better
branch
from
ea2c77f
to
a204a43
Compare
|
This HackerOne report is related: h1:212880. |
chadwhitacre
force-pushed
the
simplify-verify
branch
from
012ce92
to
68bd88d
Compare
chadwhitacre
force-pushed
the
throttle-better
branch
from
a204a43
to
5414130
Compare
|
Self-merged per #4305 (comment) and #4360 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our throttling algorithm is naive. Now that we have an isolated
queue_emailpath (#4346), we should use that as a choke-point for throttling for all user-initiated email.https://hackerone.com/reports/108645