This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Improve email subsystem #4344
Merged
Improve email subsystem #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
chadwhitacre
force-pushed
the
email-improvements
branch
from
ac76137
to
51c5819
Compare
chadwhitacre
force-pushed
the
refactor-mixins
branch
from
2d2b580
to
9463647
Compare
chadwhitacre
force-pushed
the
email-improvements
branch
2 times, most recently
from
65d7a25
to
88cc371
Compare
chadwhitacre
changed the base branch from
refactor-mixins
to
add-team-previews
|
This one is ready next, @kaguillera @nobodxbodon et al. |
|
Rebased, was 88cc371. |
chadwhitacre
force-pushed
the
email-improvements
branch
from
88cc371
to
7174836
Compare
|
I kicked Travis and we're green here again, @nobodxbodon et al. |
chadwhitacre
force-pushed
the
email-improvements
branch
from
7174836
to
055261a
Compare
|
Looks good and straightforward refactoring to me. Merging now. |
|
Awesome, thanks @nobodxbodon! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4335 turned up some dryrot. This is a start on cleaning it up.
Todo