Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Some UX cleanups for package claiming #4406

Merged
merged 6 commits into from Apr 28, 2017

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Apr 12, 2017

Part of #4305, follows on #4422.

@chadwhitacre chadwhitacre changed the base branch from master to project/claim-packages-close April 12, 2017 09:34
@chadwhitacre
Copy link
Contributor Author

Working up a new default image (no wombat):

package-default-large       image

Started with:

https://www.iconfinder.com/icons/730810/box_order_package_parcel_post_postage_shop_icon

@chadwhitacre
Copy link
Contributor Author

In situ:

screen shot 2017-04-12 at 7 28 08 am

Now for npm indicator ...

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Apr 12, 2017

More in situ:


screen shot 2017-04-12 at 7 30 48 am


screen shot 2017-04-12 at 7 30 33 am

@chadwhitacre
Copy link
Contributor Author

With the npm indicator we're coming back up against the discrepancy between the social profile listings and the project listings. I'm still not going to worry about harmonizing those yet.

screen shot 2017-04-12 at 7 34 12 am

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-04-12 at 7 54 04 am


screen shot 2017-04-12 at 7 53 30 am


screen shot 2017-04-12 at 7 54 09 am

@mattbk
Copy link
Contributor

mattbk commented Apr 12, 2017

🤤

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-cleanups branch from 4f4f8b1 to a04acf4 Compare April 12, 2017 22:01
@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Apr 12, 2017

14000e9

screen shot 2017-04-12 at 6 02 44 pm

@chadwhitacre
Copy link
Contributor Author

Short

screen shot 2017-04-12 at 6 03 35 pm

Medium

screen shot 2017-04-12 at 6 03 19 pm

Long

screen shot 2017-04-12 at 6 04 25 pm

@chadwhitacre
Copy link
Contributor Author

gratipay=# select name, char_length(description) as len from packages order by len desc limit 10;
┌──────────────────┬─────┐
│       name       │ len │
├──────────────────┼─────┤
│ tower-view       │ 939 │
│ jquery-cropbox   │ 842 │
│ shubhadownloader │ 771 │
│ perstore         │ 749 │
│ schematic        │ 719 │
│ pomelo-protobuf  │ 689 │
│ resume-generator │ 615 │
│ clever-survey    │ 585 │
│ platformenv      │ 577 │
│ JSDev            │ 563 │
└──────────────────┴─────┘
(10 rows)

gratipay=#

@chadwhitacre
Copy link
Contributor Author

Lol

screen shot 2017-04-12 at 6 08 17 pm

@chadwhitacre
Copy link
Contributor Author

Maybe we will need to vary text size based on content length?

screen shot 2017-04-12 at 6 09 02 pm

screen shot 2017-04-12 at 6 10 24 pm

@chadwhitacre
Copy link
Contributor Author

For comparison: webpack 227, mysql 110, aspen 61.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Apr 12, 2017

41d0f64

screen shot 2017-04-12 at 6 14 49 pm

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Apr 12, 2017

The opposite case. 7b71a4f

screen shot 2017-04-12 at 6 21 04 pm

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-cleanups branch from a7f668e to 7b71a4f Compare April 12, 2017 22:22
@chadwhitacre
Copy link
Contributor Author

Next up: styling unclaimed package for auth!

🤢

screen shot 2017-04-12 at 6 24 25 pm

@kaguillera
Copy link
Contributor

!m @whit537
Looks good so far.

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-04-13 at 4 31 54 pm

@chadwhitacre
Copy link
Contributor Author

gratipay=# select name, array_length(emails, 1) as n from packages where array_length(emails, 1) is not null order by n desc limit 10;
┌───────────────────┬────┐
│       name        │ n  │
├───────────────────┼────┤
│ colonel-mercator  │ 68 │
│ mapbox-file-sniff │ 66 │
│ ec2mnt            │ 66 │
│ mbview            │ 65 │
│ cfn-config        │ 64 │
│ vector-tile-query │ 64 │
│ kine              │ 64 │
│ guidance-replay   │ 61 │
│ guidance-geojson  │ 60 │
│ guidance-sim      │ 60 │
└───────────────────┴────┘
(10 rows)

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-04-14 at 2 15 15 pm

@chadwhitacre
Copy link
Contributor Author

Right, so in reality almost all addresses will be "Ready to link" for some time to come.

screen shot 2017-04-14 at 2 26 37 pm

@chadwhitacre
Copy link
Contributor Author

Working on a dropdown component (also useful for add social profile and country selector in identity page and … ?)

xej5xem8as

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-cleanups branch 3 times, most recently from d9e1f5b to 07d7e81 Compare April 15, 2017 20:25
@chadwhitacre
Copy link
Contributor Author

07d7e81

p7qgv8l0gs

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Apr 15, 2017

Okay! That was a bit of a rabbit hole, and we're not clear yet. :-)

Obviously this is still a ways from being finished, and this PR is getting big. I am thinking I will break this into multiple PRs, since there's still more to add. I'm also not sure what's going to happen when I look at this dropdown component on a phone. Could turn into a total mess.

@mattbk
Copy link
Contributor

mattbk commented Apr 17, 2017

Normal dropdowns usually degrade to mobile-friendly versions (essentially what you have) on mobile; is there a way to force that, or is there no check-for-mobile anywhere on the site?

@chadwhitacre chadwhitacre changed the title Finishing work for package claiming Some UX cleanups for package claiming Apr 17, 2017
@chadwhitacre chadwhitacre force-pushed the project/claim-packages-cleanups branch 2 times, most recently from 56e30de to 7b71a4f Compare April 17, 2017 15:54
@chadwhitacre chadwhitacre mentioned this pull request Apr 17, 2017
4 tasks
@chadwhitacre
Copy link
Contributor Author

Okay, claim form styling (inc. custom dropdown) broken out into #4410. Slew of todos moved back up to #4305.

@kaguillera
Copy link
Contributor

A little concern I have with the claiming of a package. Not sure if it should be stated her but just want to put it somewhere.
Any one of the maintainer's can claim the package, what if it is a maintainer that does not do much work on the package? Would that not be unfair? Should we leave the resolutions of that unfairness to the group of maintainers to resolve?

@chadwhitacre
Copy link
Contributor Author

Worked this through a bit w/ @kaguillera IRL.

  • Package projects still go through a review process.
  • If we notify all other maintainers then that mitigates the issue, especially if we link to the review ticket.

@chadwhitacre chadwhitacre changed the base branch from project/claim-packages-close to project/claim-packages-minor-refactor April 26, 2017 11:45
@chadwhitacre chadwhitacre changed the base branch from project/claim-packages-minor-refactor to project/claim-packages-close April 26, 2017 11:47
@chadwhitacre chadwhitacre changed the base branch from project/claim-packages-close to project/claim-packages-minor-refactor April 26, 2017 11:47
@chadwhitacre
Copy link
Contributor Author

Rebased, was 7b71a4f.

@mattbk
Copy link
Contributor

mattbk commented Apr 26, 2017

Should we leave the resolutions of that unfairness to the group of maintainers to resolve?

I think we should, at least at this stage (crossposted at #4305 (comment)).

Copy link
Contributor

@dowski dowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rusty on my CSS. Feel free to get another pair of eyes on this.

@chadwhitacre
Copy link
Contributor Author

I think we just proceed with merging if you're good, @dowski. If there's nothing downright dangerous going on here then I think we're within our risk tolerance. :)

@dowski dowski changed the base branch from project/claim-packages-minor-refactor to project/claim-packages April 28, 2017 01:54
@dowski dowski merged commit 9ebc440 into project/claim-packages Apr 28, 2017
@chadwhitacre chadwhitacre deleted the project/claim-packages-cleanups branch April 28, 2017 08:28
chadwhitacre added a commit that referenced this pull request Apr 28, 2017
chadwhitacre added a commit that referenced this pull request Apr 28, 2017
chadwhitacre added a commit that referenced this pull request May 5, 2017
chadwhitacre added a commit that referenced this pull request May 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants