Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Clean up UX some more #4411

Merged
merged 15 commits into from Apr 28, 2017

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Apr 17, 2017

Part of #4305, follows on #4410.

  • asterisk-out email addresses, ya?—let's wait for demand, these are all public in the npm registry
  • still getting a fouc on claim form?
  • add a nice mail icon for current selection in dropdown
  • add a nice dropdown arrow icon
    • highlight that instead of name on hover when closed
  • implement status icons
    • primary → feature
    • verified → success
    • unverified → [none]
    • unlinked → warning
    • other → failure
  • implement disabled (for emails linked to other accounts)
    • disable Apply button when there are no "Ready to link" emails
  • if only one email, treat differently?
    • no radio dropdown?
    • no i?
  • double-check .details (grep it)
  • make the Sign In button bigger, too
  • cross-browserize
  • seeing an off-by-one in hover state while scrolling? … bumped to Robustify custom select #4415

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-more-cleanups branch from 9141cbc to bd1bfdd Compare April 17, 2017 16:50
@chadwhitacre
Copy link
Contributor Author

91e6e45:

zkyncq4eb3

@chadwhitacre
Copy link
Contributor Author

aad63ce:

190vjs9tox

@chadwhitacre
Copy link
Contributor Author

Actually, I'm not sure the status icons work here. On the project listing there is a profile pic to take most of the visual weight. Here we don't have that, so the status icons pop ... too much, I think.

screen shot 2017-04-17 at 3 48 22 pm

@chadwhitacre
Copy link
Contributor Author

Okay. a79240d implements status icons for the most important statuses. Unlinked accounts don't have an icon.

screen shot 2017-04-17 at 4 06 57 pm

On a different account:

screen shot 2017-04-17 at 4 08 58 pm

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-more-cleanups branch from ff5cbdd to 3dd13da Compare April 17, 2017 20:43
@chadwhitacre
Copy link
Contributor Author

Actually, how about warning for half-linked? 3dd13da

screen shot 2017-04-17 at 4 39 08 pm

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-more-cleanups branch from dabe75f to 4b9fb97 Compare April 17, 2017 21:13
@chadwhitacre
Copy link
Contributor Author

4b9fb97:

eiddbk5wia

@chadwhitacre
Copy link
Contributor Author

Started hacking on disabling items in e7b90e3, will pick up with that next time.

screen shot 2017-04-17 at 5 39 12 pm

@chadwhitacre
Copy link
Contributor Author

Re: af443c9, looks like text-overflow: ellipsis can violate the padding.

screen shot 2017-04-18 at 11 31 50 am

@chadwhitacre
Copy link
Contributor Author

???

mjvgecw9jc

@chadwhitacre
Copy link
Contributor Author

Opacity generates a new stacking context.

https://philipwalton.com/articles/what-no-one-told-you-about-z-index/

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-more-cleanups branch 2 times, most recently from 098f1b6 to b068a98 Compare April 19, 2017 11:29
@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Apr 19, 2017

I tried obfuscating emails in 47eeb4c, but it looks weird. In addition to being public info, this view is also only for auth'd users.


screen shot 2017-04-19 at 7 55 20 am


screen shot 2017-04-19 at 7 56 02 am

@chadwhitacre
Copy link
Contributor Author

Let's punt on treating single emails differently. A select is still a select with only one item.

@EdOverflow
Copy link
Contributor

I tried obfuscating emails in 47eeb4c, but it looks weird. In addition to being public info, this view is also only for auth'd users.

I agree that there is no real need for obfuscation in this particular instance, but I just wanted to say that I prefer the asterisks over the dashes. 😉

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-more-cleanups branch from 47eeb4c to f05eaa4 Compare April 19, 2017 12:06
@chadwhitacre
Copy link
Contributor Author

Haven't checked in IE but working in recent Chrome, FF, Safari. Haven't checked on mobile but let's do that on a different PR.

@chadwhitacre
Copy link
Contributor Author

I really wanna make that sign-in button bigger, because it's the first impression people are going to have of Gratipay, and it just looks goofy not to match the "Apply to receive payments" button on the inside. But it's complicated because it's a template include that we use in a half dozen places and we'll need to generalize it to be able to have a large version. But then we can also use the large version on the 401 page which could potentially help address #4270.

@chadwhitacre
Copy link
Contributor Author

Aright, macro in 89c5789 ... derp, broken. :-/

Sooo ... fix that, then I'm looking at enlargening the button for the npm package page. There's already a class large in buttons.scss that's not used anywhere that I can see. But there is a larger class that's used but not defined. 🤦‍♂️

@chadwhitacre chadwhitacre mentioned this pull request Apr 21, 2017
@chadwhitacre
Copy link
Contributor Author

not used anywhere

Sike, we're using it for the "Apply to accept payments" button.

I think I'm going to hack this in pages/package.scss to avoid cross-contamination with the sign-in dropdown in the header.

@chadwhitacre
Copy link
Contributor Author

... which means we don't need the macro.

@chadwhitacre
Copy link
Contributor Author

Well, maybe it helps.

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-more-cleanups branch from 0af92cf to cd2f10c Compare April 21, 2017 20:50
@chadwhitacre
Copy link
Contributor Author

cd2f10c


gzfcuzt0v3

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Apr 21, 2017

seeing an off-by-one in hover state while scrolling?

Steps:

  1. Load a package with lots of emails, such as kine.
  2. Open select.
  3. Scroll and move mouse until you see the mouse hovering over one item but the adjacent element (above? always above?) highlighted instead.

Expected

Item under mouse is always highlighted.

Actual

Adjacent is highlighted. ☺️

@chadwhitacre
Copy link
Contributor Author

Rebased, was cd2f10c.

@chadwhitacre chadwhitacre force-pushed the project/claim-packages-more-cleanups branch from 1c6ad4b to 21e621e Compare April 27, 2017 23:40
@chadwhitacre
Copy link
Contributor Author

Rebased to pick up 47ad781 in #4410, was 1c6ad4b.

@dowski dowski changed the base branch from project/claim-packages-dropdown to project/claim-packages April 28, 2017 02:02
@dowski dowski merged commit ed59afd into project/claim-packages Apr 28, 2017
@chadwhitacre chadwhitacre deleted the project/claim-packages-more-cleanups branch April 28, 2017 08:29
chadwhitacre added a commit that referenced this pull request Apr 28, 2017
chadwhitacre added a commit that referenced this pull request Apr 28, 2017
chadwhitacre added a commit that referenced this pull request May 5, 2017
chadwhitacre added a commit that referenced this pull request May 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants