This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
[7.0.x] custom planet containers #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-palchikov
changed the title
a-palchikov
commented
Aug 7, 2020
| @@ -164,7 +164,7 @@ type healthExecutor struct { | |||
| func (p *healthExecutor) Execute(ctx context.Context) error { | |||
| p.Progress.NextStep("Waiting for the planet to start") | |||
| p.Info("Waiting for the planet to start.") | |||
| err := utils.Retry(defaults.RetryInterval, defaults.RetryAttempts, | |||
| err := utils.RetryWithInterval(ctx, defaults.ExponentialBackOff(), | |||
There was a problem hiding this comment.
Found this issue that prevents timely abort (e.g. when explicitly aborted by a user) of the installer during the planet status wait phase.
| @@ -391,113 +391,50 @@ func (s *PlanSuite) TestPlanWithIntermediateRuntimeUpdate(c *check.C) { | |||
| }) | |||
| } | |||
|
|
|||
| func (s *PlanSuite) TestUpdatesEtcdFromManifestWithoutLabels(c *check.C) { | |||
There was a problem hiding this comment.
Removed the test about assumed etcd version since it is expected that we have both installed and upgrade versions available.
wadells
reviewed
Aug 10, 2020
wadells
reviewed
Aug 10, 2020
bernardjkim
reviewed
Aug 11, 2020
bernardjkim
reviewed
Aug 11, 2020
knisbet
approved these changes
Aug 12, 2020
a-palchikov
force-pushed
the
dmitri/7.0.x/1940-baseimage
branch
from
ee273bc
to
166d95d
Compare
a-palchikov
added a commit
that referenced
this pull request
Aug 15, 2020
Otherwise, builds are subject to environment changes regarding the tele login state.
1 task
a-palchikov
added a commit
that referenced
this pull request
Aug 15, 2020
* Cherry-pick changes from #1982 to fix builds. Otherwise, builds are subject to environment changes regarding the tele login state. * Bump e
r0mant
reviewed
Aug 28, 2020
There was a problem hiding this comment.
I think that this massive builder refactoring makes this a pretty risky change esp. for an LTS release. My worry is we'll break one of our subtle tele build use-cases as we did in the past.
I would either see if it's possible to fix the custom planet problem with less of unnecessary refactoring, or extensively test all tele build use-cases (for both enterprise and open-source where applicable) to make sure nothing regresses:
- That when logged out, it pulls stuff from default hub.
- That when logged into a hub (both via "tele login" and "tsh login"), it uses that hub.
- That when --hub/--token/--repository provided, it uses the indicated hub.
- Behavior of --state-dir flag, should be source for both packages and credentials (when logged in via tele login --state-dir), and when used in conjunction with --hub/--token/--repository flags.
Maybe I'm forgetting something else...
a-palchikov
force-pushed
the
dmitri/7.0.x/1940-baseimage
branch
from
8cff16f
to
8ab796f
Compare
|
Checked the following for enterprise
|
a-palchikov
force-pushed
the
dmitri/7.0.x/1940-baseimage
branch
from
8ab796f
to
cc7b7f3
Compare
|
Hi @a-palchikov, do you think that this pr will be a part of the next release version of |
|
@dorsany I have a couple more things to take care as part of this PR that were discovered in the neighbor branch, but I hope it will. |
r0mant
approved these changes
Sep 24, 2020
a-palchikov
force-pushed
the
dmitri/7.0.x/1940-baseimage
branch
2 times, most recently
from
d84e4a8
to
b8c750c
Compare
r0mant
reviewed
Sep 28, 2020
a-palchikov
force-pushed
the
dmitri/7.0.x/1940-baseimage
branch
2 times, most recently
from
7c19daa
to
847294c
Compare
…Func for a clearer comprehension of the builder. Expose the build API key to be able to use hub/token combo to access distribution hub regardless of the login context.
… the version file to get this detail.
Read the etcd cluster version when creating the upgrade operation to use as a fallback in case the planet image does not have the etcd version information in the package manifest as expected.
a-palchikov
force-pushed
the
dmitri/7.0.x/1940-baseimage
branch
from
847294c
to
9bfc212
Compare
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward port of #1962.
Also fixes an issue with the upgrade unable to determine existing etcd server version if the planet container did not expose this information.
Type of change
Linked tickets and other PRs
TODOs
Testing done
Prerequisites
Clusters
6.1.33), 3-node cluster