Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Plugins: Support dynamic credential reloading #956

Merged
merged 13 commits into from
Nov 1, 2023

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Oct 17, 2023

Will be dependent on the v14 backport of gravitational/teleport#32974

@strideynet
Copy link
Contributor Author

In a bit of an odd situation ( as you'll see with the failed checks) where I'll need to wait for the v14 backport of the branch on teleport to be merged and then adjust the replace directives in go.mod here to point to that merge commit. I'll go ahead and open this for review regardless

Copy link
Contributor

@marcoandredinis marcoandredinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(not approving yet because the other PR is not yet backported)

event-handler/testdata/config.toml Outdated Show resolved Hide resolved
event-handler/cli.go Show resolved Hide resolved
event-handler/event_handler_test.go Outdated Show resolved Hide resolved
Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
@strideynet strideynet enabled auto-merge (squash) November 1, 2023 16:53
Copy link
Contributor

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot

@strideynet strideynet merged commit d4df9ba into master Nov 1, 2023
13 checks passed
@strideynet strideynet deleted the strideynet/plugins-support-refreshed-credentials branch November 1, 2023 17:01
rosstimothy pushed a commit that referenced this pull request Dec 4, 2023
* Modify msteams/email plugins to support reloading credentials

* Start adjusting event-handler for identity file refresh

* Fix event handler config names for refresh

* Fix test for event handler config parsing

* Adjust go.mod to depend on main repo branch

* Ignore returned user from CreateUser

* SPAG

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>

* Adjust to refer to v14 backport branch

* Fix go imports

* License header!!

---------

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
rosstimothy pushed a commit that referenced this pull request Dec 4, 2023
* Modify msteams/email plugins to support reloading credentials

* Start adjusting event-handler for identity file refresh

* Fix event handler config names for refresh

* Fix test for event handler config parsing

* Adjust go.mod to depend on main repo branch

* Ignore returned user from CreateUser

* SPAG

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>

* Adjust to refer to v14 backport branch

* Fix go imports

* License header!!

---------

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
rosstimothy pushed a commit that referenced this pull request Dec 4, 2023
* Modify msteams/email plugins to support reloading credentials

* Start adjusting event-handler for identity file refresh

* Fix event handler config names for refresh

* Fix test for event handler config parsing

* Adjust go.mod to depend on main repo branch

* Ignore returned user from CreateUser

* SPAG

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>

* Adjust to refer to v14 backport branch

* Fix go imports

* License header!!

---------

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants