Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access Plugins: Support dynamic credential reloading #32974

Merged
merged 12 commits into from
Nov 1, 2023
Merged

Access Plugins: Support dynamic credential reloading #32974

merged 12 commits into from
Nov 1, 2023
+134 −202

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Oct 4, 2023 •
edited

This PR:

  • Refactors the access plugin's creation of the Teleport client to a single location rather than repeating this for each client. Adding new functionality would've involved me adding this at each of the client creation points and this seemed a bit silly to me.
  • Adds a new configuration option to enable identity file reloading and to configure the interval

Before merging, wait for the Teleport Plugins PR: gravitational/teleport-plugins#956

changelog: Introduces support for configuring Access Plugins to automatically refresh the identity file from disk. This improves compatibility with Machine ID as a credential source.

@strideynet strideynet mentioned this pull request Oct 17, 2023
Merged
@strideynet strideynet marked this pull request as ready for review October 19, 2023 10:30
marcoandredinis
marcoandredinis approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@marcoandredinis marcoandredinis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I assume you tested these changes

@github-actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@marcoandredinis marcoandredinis mentioned this pull request Oct 30, 2023
Merged
@strideynet strideynet mentioned this pull request Oct 31, 2023
Merged
@strideynet strideynet added this pull request to the merge queue Nov 1, 2023
Merged via the queue into master with commit 516e15d Nov 1, 2023
34 checks passed
@strideynet strideynet deleted the strideynet/plugins-support-refreshed-credentials branch November 1, 2023 17:13
@public-teleport-github-review-bot
Copy link

@strideynet See the table below for backport results.

Branch Result
branch/v14 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@hugoShaka hugoShaka hugoShaka approved these changes

Assignees
No one assigned
Labels
backport/branch/v14 size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@strideynet @marcoandredinis @hugoShaka