-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent web ui SSH connections from leaking (#41518)
The session closing in TerminalHandler.Close did not always close established ssh sessions if the client closed the web socket at any point between the new browser tab being opened and the session being established. In these cases the SSH connection was leaked for the duration of the Proxy process. To ensure sessions are always terminated a check to see if the client closed the web socket was added prior to writing the session metadata and after the shell is established for the ssh session.
- Loading branch information
1 parent
81eeb25
commit 5379d01
Showing
2 changed files
with
128 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters