Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestProxySSHJumpHost/TLS_routing_enabled_for_root_and_disabled_for_leaf flakiness #39578

Closed
rosstimothy opened this issue Mar 19, 2024 · 4 comments · Fixed by #39590 or #40052
Closed

TestProxySSHJumpHost/TLS_routing_enabled_for_root_and_disabled_for_leaf flakiness #39578

rosstimothy opened this issue Mar 19, 2024 · 4 comments · Fixed by #39590 or #40052
Assignees
@Joerger
Labels
flaky tests

Comments

@rosstimothy
Copy link
Contributor

Failure

Link(s) to logs

Relevant snippet

FAIL: tool/tsh/common TestProxySSHJumpHost/TLS_routing_enabled_for_root_and_disabled_for_leaf (10.69s)
    testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
@rosstimothy rosstimothy mentioned this issue Mar 19, 2024
Merged
rosstimothy added a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky
0966d68 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky (#39590)
0893469 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
github-actions bot pushed a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky
7d0f152 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
github-actions bot pushed a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky
cfd100c 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
github-actions bot pushed a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky
0eecb42 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky (#39597)
7c0d703 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky (#39596)
fe5aff3 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
@rosstimothy
Make TestProxySSHJumpHost less flaky (#39598)
9fa740a 
Disables disk-based session recording mode for all subtests
to prevent writing to disk after the test concludes.

```
testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_enabled_for_root_and_disabled_for_leaf132326872/002: directory not empty
```

Fixes #39578
@Tener
Copy link
Contributor

Tener commented Mar 25, 2024 •
edited
Loading 

=== Failed
=== FAIL: tool/tsh/common TestProxySSHJumpHost/TLS_routing_disabled_for_root_and_leaf (11.24s)

Link: https://github.com/gravitational/teleport/actions/runs/8422377210/job/23061534040?pr=39773

Although I can't find unlinkat error in this one... might be a different root cause?

@Tener Tener reopened this Mar 25, 2024
@Tener
Copy link
Contributor

Tener commented Mar 26, 2024 •
edited
Loading

This caused some merge queue failures, most recently: https://github.com/gravitational/teleport/actions/runs/8435129648/job/23099850963

=== FAIL: tool/tsh/common TestProxySSHJumpHost/TLS_routing_disabled_for_root_and_leaf (11.33s)
    testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_disabled_for_root_and_leaf3707765129: directory not empty

@espadolini
Copy link
Contributor

Plenty of flakes here today, all beause of cleaning up the tempdir after the test was supposed to be ended.
https://github.com/gravitational/teleport/actions/runs/8483026485/job/23243390757

@Joerger Joerger mentioned this issue Mar 29, 2024
Merged
@ibeckermayer
Copy link
Contributor

Another one here bumped me out of the merge queue: https://github.com/gravitational/teleport/actions/runs/8516671584/job/23326048741

testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestProxySSHJumpHostTLS_routing_disabled_for_root_and_enabled_for_leaf2852336502: directory not empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joerger Joerger

Labels
flaky tests
Projects
None yet
Milestone
No milestone
5 participants
@Tener @espadolini @ibeckermayer @Joerger @rosstimothy