-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] Don't hard-code .cluster.local
in the teleport-cluster
chart
#41165
Labels
feature-request
Used for new features in Teleport, improvements to current should be #enhancements
helm
kube-operator
Issues related to Kube Operator
Comments
programmerq
added
feature-request
Used for new features in Teleport, improvements to current should be #enhancements
helm
kube-operator
Issues related to Kube Operator
labels
May 2, 2024
tigrato
added a commit
that referenced
this issue
May 8, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster domain address when running clusters with non default cluster domains. Fixes #41165 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this issue
May 9, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster domain address when running clusters with non default cluster domains. Fixes #41165 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this issue
May 9, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster domain address when running clusters with non default cluster domains. Fixes #41165 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this issue
May 9, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster domain address when running clusters with non default cluster domains. Fixes #41165 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature-request
Used for new features in Teleport, improvements to current should be #enhancements
helm
kube-operator
Issues related to Kube Operator
What would you like Teleport to do?
Kubernetes allows cluster administrators to choose a value other than
cluster.local
. This means that our chart's hard-coded use leads to failures on a Kubernetes cluster that doesn't use the default value.https://github.com/gravitational/teleport/blob/master/examples/chart/teleport-cluster/templates/_helpers.tpl#L90
A common paradigm in the helm community is to include a
clusterDomain
value that defaults tocluster.local
. An alternate approach would be to avoid using the FQDN and instead rely on the short DNS names (if feasible).Here's an example in the bitnami etcd chart:
https://github.com/bitnami/charts/blob/main/bitnami/etcd/values.yaml#L49-L51
https://github.com/bitnami/charts/blob/main/bitnami/etcd/templates/statefulset.yaml#L182-L183
The text was updated successfully, but these errors were encountered: