Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Don't hard-code .cluster.local in the teleport-cluster chart #41165

Closed
programmerq opened this issue May 2, 2024 · 0 comments · Fixed by #41311
Closed

[helm] Don't hard-code .cluster.local in the teleport-cluster chart #41165

programmerq opened this issue May 2, 2024 · 0 comments · Fixed by #41311
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements helm kube-operator Issues related to Kube Operator

Comments

@programmerq
Copy link
Contributor

What would you like Teleport to do?

Kubernetes allows cluster administrators to choose a value other than cluster.local. This means that our chart's hard-coded use leads to failures on a Kubernetes cluster that doesn't use the default value.

https://github.com/gravitational/teleport/blob/master/examples/chart/teleport-cluster/templates/_helpers.tpl#L90

% grep -Ri 'serviceFQDN' .
./charts/teleport-operator/templates/_helpers.tpl:{{- $clusterAddr := include "teleport-cluster.auth.serviceFQDN" . -}}
./charts/teleport-operator/templates/_helpers.tpl:{{- define "teleport-cluster.auth.serviceFQDN" -}}{{- end }}
./templates/proxy/_config.common.tpl:  auth_server: "{{ include "teleport-cluster.auth.serviceFQDN" . }}:3025"
./templates/auth/_config.common.tpl:  public_addr: "{{ include "teleport-cluster.auth.serviceFQDN" . }}:3026"
./templates/_helpers.tpl:{{- define "teleport-cluster.auth.serviceFQDN" -}}

A common paradigm in the helm community is to include a clusterDomain value that defaults to cluster.local. An alternate approach would be to avoid using the FQDN and instead rely on the short DNS names (if feasible).

Here's an example in the bitnami etcd chart:

https://github.com/bitnami/charts/blob/main/bitnami/etcd/values.yaml#L49-L51
https://github.com/bitnami/charts/blob/main/bitnami/etcd/templates/statefulset.yaml#L182-L183

@programmerq programmerq added feature-request Used for new features in Teleport, improvements to current should be #enhancements helm kube-operator Issues related to Kube Operator labels May 2, 2024
tigrato added a commit that referenced this issue May 8, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot pushed a commit that referenced this issue May 8, 2024
…41311)

This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato added a commit that referenced this issue May 9, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato added a commit that referenced this issue May 9, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato added a commit that referenced this issue May 9, 2024
This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
…41331)

This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
…41356)

This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
…41355)

This PR allows users to set `clusterDomain` to match Kubernetes Cluster
domain address when running clusters with non default cluster domains.

Fixes #41165

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements helm kube-operator Issues related to Kube Operator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant