[v9] Fix meaning of bot_name in bot join tokens (#11039)
#11047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BotName` / `bot_name` was previously used to refer to the bot _username_ rather than the bot name as entered by users. This leads to confusion as the username is an implemention detail not obviously visible to users. This changes the meaning of the `bot_name` parameter to instead consistently accept a bot name, which is converted to a username on the backend where needed.
github-actions
bot
requested review from
nklaassen,
probakowski,
smallinsky and
zmb3
timothyb89
changed the title
bot_name in bot join tokens (#11039)bot_name in bot join tokens (#11039)
nklaassen
approved these changes
Mar 10, 2022
r0mant
approved these changes
Mar 10, 2022
zmb3
approved these changes
Mar 10, 2022
russjones
approved these changes
Mar 10, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11039 for branch/v9
The
BotName/bot_namewas previously used to refer to the botusername rather than the bot name as entered by users. This leads
to confusion as the username is an implemention detail not obviously
visible to users.
This changes the meaning of the
bot_nameparameter to insteadconsistently accept a bot name, which is converted to a username on
the backend where needed.