opened in error #12068
Closed
opened in error #12068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also add windows desktops sorter and its type converters * Use forked vulcand/predicate library: allows traversing by embedded fields Part of RFD 55
* Include tbot binary in Teleport packages and installs This includes the tbot binary in .rpm, .deb, and .pkg distributions, and ensures the binary is installed using the `install` script in .tar.gz packages. * Remove tbot from macOS client-only builds
The upload completer scans for uploads that need to be completed, likely due to an error or process restart. Prior to this change, it only completed uploads that had 1 or more parts. Since completing an upload is what cleans up the directory on disk (or in the case of cloud storage, finishes the multipart upload), it was possible for us to leave behind empty directories (or multipart uploads) for uploads with no parts. This change makes it valid to complete uploads with no parts, which ensures that these directories get cleaned up. Also fix an issue with the GCS uploader, which failed to properly calculate the upload ID from the path. This is because strings.Split(s, "/") returns an empty string as the last element when s ends with a /. Updates #9646
Ensure that the logic which checks for (and emits) a session.end event also applies for windows.desktop.session.end events. For this to work, we use the StreamSessionEvents API instead of GetEvents. This is because the streaming API works for any stream of audit events, and GetSessionEvents is specific to SSH and the chunks index format used by SSH sessions. Lastly, ensure that desktop related events are also captured in the session recording stream (but omitted when streaming the events to the browser during session playback). This allows us to use the start event in order to reconstruct a missing end event.
When completing a file-based upload, open the parts files one at a time and write them to the upload, closing each file before opening the next one. This is preferrable to opening them all at once and closing all files at the end, because it consumes less file descriptors. Updates #10660
…10844) (#10911) Before this commit, if `--proxy` was set, it would be passed as it to the kubeconfig file. Due to this, if the `--proxy` URL did not have a scheme, it would default to `http`, leading to the issue reported in https://github.com/gravitational/cloud/issues/1358. With this commit, we now try to parse the `--proxy` URL and set its scheme to `https` in case it's not set. In case it's set, we only allow `--proxy` URLs with the `http` and `https` schemes.
b6756348 Disable autocomplete on the SSH login input (gravitational/webapps#605) (gravitational/webapps#639) gravitational/webapps@b6756348 In addition, Desktops: * Fix clipboard sync * Maintain aspect ratio on Desktop Playback * only synchronize clipboards if data was or is going to be sent * desktop playback error handling * smooth out progress bar Others: * Use role v5, all protocols, reduced RBAC * Simplify add node instructions [source: -w teleport-v9] [target: -t branch/v9]
Send COM_QUIT message when closing MySQL connection. Backport #10984 to branch/v9
Add support for MariaDB AWS RDS with IAM authentication version 10.6+. Backport #10333 Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> Co-authored-by: Alan Parra <alan.parra@goteleport.com> Co-authored-by: Roman Tkachenko <roman@goteleport.com>
* docs: update database guides to use configurator * Apply suggestions from code review Co-authored-by: Roman Tkachenko <roman@goteleport.com> * docs(database): add auto-discovery IAM policies reference * docs(database): update with code review suggestions * docs(database): update with review suggestions * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * docs(database): remove H3 lines * docs(database): update auto-discovery reference * docs(database): update policy examples to be more restrictive * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> Co-authored-by: Roman Tkachenko <roman@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> Co-authored-by: Roman Tkachenko <roman@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Fix several issues in the installation page: - Update links gravitational.io -> goteleport.com - Remove section on building from source and link to the README instead (the README will always be more up to date, and if you're comfortable building from source you're probably accustomed to looking there anyway)
) (#12042) * feat(tctl): sign command to generate database access credentials * feat(tctl): make auth sign parameters app-name and db-name mutually exclusive * feat(tctl): add flag db-user to auth sign command * test(tctl): remove references to deprecated package ioutil * test(tctl): update test to check error type * chore(tctl): add godoc to `getDatabaseServer` function * refactor(tctl): rename database-related flags in auth sign * refactor(tctl): rename flag from `db` to `db-service`
Original behaviour did not take effect in CI due to a different entrypoint. This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability. Updates #11940
github-actions
bot
added
application-access
audit-log
github-actions
bot
requested review from
jimbishopp,
ptgott,
r0mant,
xinding33 and
zmb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.