Silence false positive lints from staticcheck in tbot/init.go #11084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`staticcheck` does not seem to appreciate our nop implementations for non-Linux OSes and produces several noisy warnings about it. This disables the lints as precisely as possible.
greedy52
approved these changes
Mar 12, 2022
Comment on lines
91
to
93
| func VerifyACL(path string, opts *ACLOptions) error { | ||
| return trace.NotImplemented("ACLs not supported on this platform") | ||
| } |
There was a problem hiding this comment.
Suggested change
| func VerifyACL(path string, opts *ACLOptions) error { | |
| return trace.NotImplemented("ACLs not supported on this platform") | |
| } | |
| func VerifyACL(path string, opts *ACLOptions) error { | |
| if false { | |
| return nil | |
| } | |
| return trace.NotImplemented("ACLs not supported on this platform") | |
| } |
I think you can trick the linter like this.
//nolint:staticcheck is also good as long as we remember clean them later. Thanks for fixing!
rosstimothy
approved these changes
Mar 14, 2022
timothyb89
added a commit
that referenced
this pull request
Mar 14, 2022
`staticcheck` does not seem to appreciate our nop implementations for non-Linux OSes and produces several noisy warnings about it. This disables the lints as precisely as possible.
timothyb89
added a commit
that referenced
this pull request
Mar 16, 2022
#11128) `staticcheck` does not seem to appreciate our nop implementations for non-Linux OSes and produces several noisy warnings about it. This disables the lints as precisely as possible.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
staticcheckdoes not seem to appreciate our nop implementations for non-Linux OSes and produces several noisy warnings about it. This disables the lints as precisely as possible.