Support role bootstrapping in OSS #11175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
approved these changes
Mar 16, 2022
codingllama
approved these changes
Mar 16, 2022
| RegisterResourceMarshaler(types.KindUser, func(r types.Resource, opts ...MarshalOption) ([]byte, error) { | ||
| rsc, ok := r.(types.User) | ||
| RegisterResourceMarshaler(types.KindUser, func(resource types.Resource, opts ...MarshalOption) ([]byte, error) { | ||
| user, ok := resource.(types.User) |
There was a problem hiding this comment.
Thanks for being thorough, nice.
jakule
approved these changes
Mar 17, 2022
espadolini
added a commit
that referenced
this pull request
Mar 18, 2022
* Add role bootstrapping * Test coverage * Better variable names * Remove spurious log, add better error messages
espadolini
added a commit
that referenced
this pull request
Mar 18, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this is merged we can remove the dynamic marshaler registration in gravitational/teleport.e#416.
Replaces #7130.
Doublecheck the behavior of
lib/auth.migrateLegacyResourceswhen backporting this, as the migration will apply to the bootstrapped resources.