Edit the Database Access GUI guide for Cloud users #11801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
force-pushed
the
paul.gottschling/10637-gui-clients
branch
from
b0f5683
to
94199ac
Compare
ptgott
force-pushed
the
paul.gottschling/10637-gui-clients
branch
from
94199ac
to
c6a77b8
Compare
zmb3
reviewed
Apr 12, 2022
Comment on lines
209
to
210
| Teleport's DBeaver MySQL integration only supports MySQL server | ||
| (=mysql.dbeaver_min_ver=) or older. |
There was a problem hiding this comment.
Should we say "only supports versions up to (=mysql.dbeaver_min_ver=)" instead?
As I was reading this sentence, I was almost certain it was going to end with "or newer" just because that's normally how compatibility notes read. This one caught me by surprise.
r0mant
approved these changes
Apr 12, 2022
ptgott
force-pushed
the
paul.gottschling/10637-gui-clients
branch
2 times, most recently
from
e1d1e12
to
7bdcdb7
Compare
zmb3
approved these changes
Apr 13, 2022
See #10637 - Add a Prerequisites section with tabs for different scopes - Use a ScopedBlock so the "Get connection information" section only shows connection options that are relevant to a particular scope. - Where the guide refers to a particular "tsh" command that doesn't apply to all scopes, refer to the "Get connection information" section instead. - Light copy-edits for style, clarity, and grammar
ptgott
force-pushed
the
paul.gottschling/10637-gui-clients
branch
from
7bdcdb7
to
18c4718
Compare
ptgott
added a commit
that referenced
this pull request
Apr 15, 2022
* Edit the Database Access GUI guide for Cloud users See #10637 - Add a Prerequisites section with tabs for different scopes - Use a ScopedBlock so the "Get connection information" section only shows connection options that are relevant to a particular scope. - Where the guide refers to a particular "tsh" command that doesn't apply to all scopes, refer to the "Get connection information" section instead. - Light copy-edits for style, clarity, and grammar * Respond to PR feedback
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10637
shows connection options that are relevant to a particular scope.
apply to all scopes, refer to the "Get connection information"
section instead.