[v7] Client timeout fixes #12634
Merged
[v7] Client timeout fixes #12634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
approved these changes
May 13, 2022
|
Well, it's the backport of all the relevant changes in the original PR, it just happens to be only one 🥲 |
zmb3
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #12557 to branch/v7
Only the timeout in
webclientwas added, as v7 doesn't have TLS routing. Unlike thewebclientinmaster, the timeout is unconditionally set todefaults.DialTimeout. This will need changes if we end up needing different timeouts in different places.