Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain to Go 1.19 #16479

Merged
merged 6 commits into from
Sep 19, 2022
Merged

Update toolchain to Go 1.19 #16479

merged 6 commits into from
Sep 19, 2022

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Sep 16, 2022

Update Go toolchain, allowing for a possible go.mod bump to 1.19.

Since Go 1.19 BoringCrypto is no longer a separate branch, but instead it's enabled by a GOEXPERIMENT.

Release notes: https://tip.golang.org/doc/go1.19.

@@ -2,7 +2,7 @@

# If this build was triggered from a tag on the teleport repo,
# then assume we can use the same tag for the webapps repo.
if [ ! -z "$DRONE_TAG" ]
if [ -n "$DRONE_TAG" ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my shellcheck version is newer, but this won't hurt anyway.

@codingllama codingllama marked this pull request as ready for review September 16, 2022 22:15
@codingllama
Copy link
Contributor Author

FIPS:

$ docker run \
  --rm=true \
  -v "$(pwd)":/go/src/github.com/gravitational/teleport \
  -v /tmp:/tmp \
  -w /go/src/github.com/gravitational/teleport \
  -h buildbox \
  -e GOMODCACHE=/tmp/gomodcache \
  -ti \
  -u $(id -u):$(id -g) \
  -e HOME=/go/src/github.com/gravitational/teleport/build.assets \
  public.ecr.aws/gravitational/teleport-buildbox-fips:teleport11 \
  /bin/bash  # stolen from `make enter`
$ go version
> go version go1.19.1 linux/amd64
$ go build ./tool/tsh
$ go version tsh
> tsh: go1.19.1 X:boringcrypto

Centos7 FIPS:

# Enter Docker as above.
$ go version
> go version go1.19.1 linux/amd64
$ go build ./tool/tsh
$ go version tsh
> tsh: go1.19.1 X:boringcrypto

@@ -23,18 +23,14 @@ OS ?= linux
ARCH ?= amd64
BUILDBOX_VERSION ?= teleport11

# NOTE: Windows Drone scripts hardcode $GOLANG_VERSION rather than drawing it
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are misleading, dronegen/windows.go seems to use make print-go-version and make print-node-version now.

@codingllama codingllama force-pushed the codingllama/go1.19 branch 2 times, most recently from e0d47ce to e62b221 Compare September 19, 2022 14:29
@codingllama codingllama merged commit 9bb0255 into master Sep 19, 2022
@codingllama codingllama deleted the codingllama/go1.19 branch September 19, 2022 17:33
codingllama added a commit that referenced this pull request Sep 19, 2022
Fixes integration test breakage caused by #16479.

* Set and manage GOCACHE for integration tests
codingllama added a commit that referenced this pull request Dec 8, 2022
Update the v10 branches to the latest Go minor release.

FIPS image changes cloned from #16479.
codingllama added a commit that referenced this pull request Dec 9, 2022
Fixes integration test breakage caused by #16479.

* Set and manage GOCACHE for integration tests
fheinecke pushed a commit that referenced this pull request Dec 16, 2022
Update the v10 branches to the latest Go minor release.

FIPS image changes cloned from #16479.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants