New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v10] Update Go to 1.19.4 #19155
Merged
Merged
[v10] Update Go to 1.19.4 #19155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
requested review from
rosstimothy and
zmb3
and removed request for
jakule and
xacrimon
December 7, 2022 17:43
FIPS: teleport-buildbox-fips: $ make -C build.assets buildbox-fips
$ docker run \
--rm -it -u $(id -u):$(id -g) \
-e GOMODCACHE=/tmp/gomodcache \
-e HOME=/go/src/github.com/gravitational/teleport/build.assets \
-h buildbox \
-v "$(pwd)":/go/src/github.com/gravitational/teleport \
-v /tmp:/tmp \
-w /go/src/github.com/gravitational/teleport \
public.ecr.aws/gravitational/teleport-buildbox-fips:teleport10 \
/bin/bash
$ go version # inside buildbox
> go version go1.19.4 linux/amd64
$ go env | grep -i boring
> GOEXPERIMENT="boringcrypto"
$ go run ./hellofips.go # import _ "crypto/tls/fipsonly"
> Hello FIPS teleport-buildbox-centos7-fips: (Same checks.) |
A basic |
zmb3
approved these changes
Dec 7, 2022
codingllama
force-pushed
the
codingllama/v10-go-1.19
branch
from
December 7, 2022 18:19
5fe9e9d
to
f77b027
Compare
nklaassen
approved these changes
Dec 7, 2022
codingllama
force-pushed
the
codingllama/v10-go-1.19
branch
from
December 7, 2022 22:26
f77b027
to
dcb35dd
Compare
codingllama
force-pushed
the
codingllama/v10-go-1.19
branch
from
December 8, 2022 17:07
dcb35dd
to
e85dc76
Compare
fheinecke
pushed a commit
that referenced
this pull request
Dec 16, 2022
Update the v10 branches to the latest Go minor release. FIPS image changes cloned from #16479.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the v10 branches to the latest Go minor release.
FIPS image changes cloned from #16479.