[v11] Add rate limiter to saml/oidc routes #19950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfreiberg
force-pushed
the
sfreiberg/add-ent-rate-limits-v11
branch
from
609599c
to
04a89dd
Compare
jentfoo
approved these changes
Jan 6, 2023
avatus
changed the title
avatus
approved these changes
Jan 6, 2023
sfreiberg
force-pushed
the
sfreiberg/add-ent-rate-limits-v11
branch
from
04a89dd
to
9212282
Compare
codingllama
approved these changes
Jan 6, 2023
| @@ -598,13 +598,13 @@ func (h *Handler) bindDefaultEndpoints() { | |||
| // OIDC related callback handlers | |||
| h.GET("/webapi/oidc/login/web", h.WithRedirect(h.oidcLoginWeb)) | |||
| h.GET("/webapi/oidc/callback", h.WithMetaRedirect(h.oidcCallback)) | |||
| h.POST("/webapi/oidc/login/console", httplib.MakeHandler(h.oidcLoginConsole)) | |||
| h.POST("/webapi/oidc/login/console", h.WithLimiter(h.oidcLoginConsole)) | |||
There was a problem hiding this comment.
Not here, since it's a backport of sorts, but should we add a test to verify that certain routes are rate-limited, so we can prevent regressions?
There was a problem hiding this comment.
I don't think I have enough context to give a meaningful answer. My optimistic side hopes that would get caught in a code review but I know these kinds of invisible things are easy to miss.
sfreiberg
force-pushed
the
sfreiberg/add-ent-rate-limits-v11
branch
from
9212282
to
134235d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of adding the rate limiter to routes that are currently in the
esubmodule but in v11 were in the main repo. It is an extension of #19869.