Enable IP pinning enforcement for Kube and DB #22310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAM
added
kubernetes-access
database-access
AntonAM
force-pushed
the
anton/ip-pinning-kube-db
branch
5 times, most recently
from
3f71a11
to
96d9f94
Compare
AntonAM
changed the title
AntonAM
force-pushed
the
anton/ip-propagation-reverse-tunnel
branch
from
f3985ab
to
6085014
Compare
AntonAM
force-pushed
the
anton/ip-pinning-kube-db
branch
from
96d9f94
to
9ea3d08
Compare
AntonAM
force-pushed
the
anton/ip-propagation-reverse-tunnel
branch
5 times, most recently
from
89c7e95
to
75497fa
Compare
AntonAM
changed the base branch from
anton/ip-propagation-reverse-tunnel
to
master
AntonAM
force-pushed
the
anton/ip-pinning-kube-db
branch
4 times, most recently
from
95e4b28
to
6b581c2
Compare
|
@strideynet @espadolini @rosstimothy hey folks, sorry for being pushy, but it would be great if you could prio this review 🙏 (this feature is scheduled for 12.1 release) |
AntonAM
force-pushed
the
anton/ip-pinning-kube-db
branch
from
80b300f
to
3fea6ce
Compare
smallinsky
approved these changes
Mar 7, 2023
public-teleport-github-review-bot
bot
removed request for
espadolini,
greedy52 and
strideynet
AntonAM
force-pushed
the
anton/ip-pinning-kube-db
branch
from
3fea6ce
to
11fe6ba
Compare
tigrato
approved these changes
Mar 8, 2023
AntonAM
force-pushed
the
anton/ip-pinning-kube-db
branch
from
f7f5362
to
cbb835c
Compare
AntonAM
added a commit
that referenced
this pull request
Mar 9, 2023
AntonAM
added a commit
that referenced
this pull request
Mar 10, 2023
AntonAM
added a commit
that referenced
this pull request
Mar 20, 2023
AntonAM
added a commit
that referenced
this pull request
Mar 29, 2023
AntonAM
added a commit
that referenced
this pull request
Mar 31, 2023
AntonAM
added a commit
that referenced
this pull request
Apr 3, 2023
AntonAM
added a commit
that referenced
this pull request
Apr 3, 2023
* Add secure client IP propagation throughout teleport (#21080) * Allow node to handle old and new way of client IP propagation on same listener With addition of signed PROXY headers, node was listening on multiplexer, but because of that it couldn't processing incoming connection from older proxies when ProxyHelloSignature was used, because both ends were waiting for the other side to send data first. Here we integrate ability to handle PROXY headers into connection itself, so we can start ssh server without waiting for multiplexer to detect connection * Enabled IP pinning enforcement for Kube and DB (#22310) * Don't allow different tcp version IP addresses in signed PROXY headers * Send signed proxy header to the kube service Because it was checking version, which was empty, signed headers were not sent, when we contacted leaf cluster's kube service * Temporary disable ip propagation tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables enforcement of IP pinning for Kube and DB services (as part of #22061).
Should be merged after #21080 .
I've included both Kube and DB in one PR since they share checking function and actual functionality changes are not that large, only ~150 lines, most of the changes are tests.