New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v12] Backport IP pinning for Kube and DB access #23418
Merged
AntonAM
merged 6 commits into
branch/v12
from
anton/backport-21080-22572-22310-22716-23386-branch/v12
Apr 3, 2023
Merged
[v12] Backport IP pinning for Kube and DB access #23418
AntonAM
merged 6 commits into
branch/v12
from
anton/backport-21080-22572-22310-22716-23386-branch/v12
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAM
added
kubernetes-access
database-access
Database access related issues and PRs
backport
labels
Mar 22, 2023
This was referenced Mar 22, 2023
AntonAM
force-pushed
the
anton/backport-21080-22572-22310-22716-23386-branch/v12
branch
2 times, most recently
from
March 29, 2023 00:37
0a80140
to
ea5660d
Compare
espadolini
approved these changes
Mar 30, 2023
@AntonAM - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
strideynet
approved these changes
Mar 30, 2023
rosstimothy
approved these changes
Mar 30, 2023
r0mant
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntonAM Approved but added do-not-merge label for now, until we publish 12.1.3.
@r0mant |
AntonAM
force-pushed
the
anton/backport-21080-22572-22310-22716-23386-branch/v12
branch
from
March 31, 2023 04:50
ea5660d
to
4c5131c
Compare
mdwn
approved these changes
Mar 31, 2023
… listener With addition of signed PROXY headers, node was listening on multiplexer, but because of that it couldn't processing incoming connection from older proxies when ProxyHelloSignature was used, because both ends were waiting for the other side to send data first. Here we integrate ability to handle PROXY headers into connection itself, so we can start ssh server without waiting for multiplexer to detect connection
Because it was checking version, which was empty, signed headers were not sent, when we contacted leaf cluster's kube service
AntonAM
force-pushed
the
anton/backport-21080-22572-22310-22716-23386-branch/v12
branch
from
April 3, 2023 14:05
4c5131c
to
e29dd8b
Compare
AntonAM
deleted the
anton/backport-21080-22572-22310-22716-23386-branch/v12
branch
April 3, 2023 15:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports enabling of IP pinning for Kube and DB access, specifically it backports #21080 #22572 #22310 #22716 and #23386
Part of #22061