Don't allow different tcp version IP addresses in signed PROXY headers #22716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
approved these changes
Mar 7, 2023
zmb3
reviewed
Mar 7, 2023
AntonAM
force-pushed
the
anton/proxy-headers-different-tcp-versions
branch
from
2774565
to
ad08923
Compare
zmb3
approved these changes
Mar 7, 2023
public-teleport-github-review-bot
bot
removed request for
hatched and
probakowski
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
AntonAM
force-pushed
the
anton/proxy-headers-different-tcp-versions
branch
from
ad08923
to
4b8fa2e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that we only create signed PROXY headers if both source and destination IP addresses are same TCP version (This was causing problems for web UI file transfers).